Commit 0a0317b4 authored Aug 10, 2012 by Cody P Schafer Committed by Arnaldo Carvalho de Melo Aug 13, 2012

perf symbols: Simplify out_fixup in kernel syms loading



The only site that jumps to out_fixup has (kallsyms_filename == NULL).
And all paths that reach 'if (err > 0)' without 'goto out_fixup' have
kallsyms_filename != NULL.

So skip over both the check & dso__set_long_name(), and remove the
check.

Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: David Hansen <dave@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Matt Hellsley <matthltc@us.ibm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/1344637382-22789-8-git-send-email-cody@linux.vnet.ibm.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 82151520

tools/perf/util/symbol.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1503,9 +1503,8 @@ do_kallsyms:
		free(kallsyms_allocated_filename);

		if (err > 0) {
		out_fixup:
		if (kallsyms_filename != NULL)
		dso__set_long_name(dso, strdup("[kernel.kallsyms]"));
		out_fixup:
		map__fixup_start(map);
		map__fixup_end(map);
		}

Admin message