r8169: add constant EnAnaPLL (09e65335) · Commits · 戴 / test

Use constant EnAnaPLL for bit 14 as in vendor driver. The vendor driver sets this bit for chip version 02 only, but I'm not aware of any issues, so better leave it as it is. In addition remove the useless debug message. Signed-off-by:

Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/realtek/r8169_main.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -492,6 +492,7 @@ enum rtl_register_content {
		/* CPlusCmd p.31 */
		EnableBist = (1 << 15), // 8168 8101
		Mac_dbgo_oe = (1 << 14), // 8168 8101
		EnAnaPLL = (1 << 14), // 8169
		Normal_mode = (1 << 13), // unused
		Force_half_dup = (1 << 12), // 8168 8101
		Force_rxflow_en = (1 << 11), // 8168 8101
		@@ -5212,11 +5213,8 @@ static void rtl_hw_start_8169(struct rtl8169_private *tp)
		tp->cp_cmd \|= PCIMulRW;

		if (tp->mac_version == RTL_GIGA_MAC_VER_02 \|\|
		tp->mac_version == RTL_GIGA_MAC_VER_03) {
		netif_dbg(tp, drv, tp->dev,
		"Set MAC Reg C+CR Offset 0xe0. Bit 3 and Bit 14 MUST be 1\n");
		tp->cp_cmd \|= (1 << 14);
		}
		tp->mac_version == RTL_GIGA_MAC_VER_03)
		tp->cp_cmd \|= EnAnaPLL;

		RTL_W16(tp, CPlusCmd, tp->cp_cmd);

Admin message