Commit 09cedbef authored Feb 04, 2012 by Yinghai Lu Committed by Jesse Barnes Feb 17, 2012

PCI: Fix /sys warning when sriov enabled and card is hot removed



sysfs is a bit stricter now and emits warnings in more cases.

For SRIOV hotplug, we are calling pci_stop_dev() for each VF first
(after we update pci_stop_bus_devices) which remove each VF subdir.  So
double check the VF dir in /sys before trying to remove the physfn link.

Signed-of-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

parent ad71c962

drivers/pci/iov.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -173,6 +173,12 @@ static void virtfn_remove(struct pci_dev *dev, int id, int reset)

		sprintf(buf, "virtfn%u", id);
		sysfs_remove_link(&dev->dev.kobj, buf);
		/*
		* pci_stop_dev() could have been called for this virtfn already,
		* so the directory for the virtfn may have been removed before.
		* Double check to avoid spurious sysfs warnings.
		*/
		if (virtfn->dev.kobj.sd)
		sysfs_remove_link(&virtfn->dev.kobj, "physfn");

		mutex_lock(&iov->dev->sriov->lock);

Admin message