Commit 09ceb8d7 authored Jul 31, 2020 by Andy Shevchenko Committed by Sergey Senozhatsky Aug 01, 2020

lib/vsprintf: Replace custom spec to print decimals with generic one



When printing phandle via %pOFp the custom spec is used. First of all,
it has a SMALL flag which makes no sense for decimal numbers. Second,
we have already default spec for decimal numbers. Use the latter in
the %pOFp case as well.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Joe Perches <joe@perches.com>
Cc: Grant Likely <grant.likely@arm.com>
Link: https://lore.kernel.org/r/20200731180825.30575-2-andriy.shevchenko@linux.intel.com


Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

parent b886690d

lib/vsprintf.c

+1 −7

Original line number	Diff line number	Diff line
		@@ -1979,12 +1979,6 @@ char device_node_string(char buf, char end, struct device_node dn,
		char *buf_start = buf;
		struct property *prop;
		bool has_mult, pass;
		static const struct printf_spec num_spec = {
		.flags = SMALL,
		.field_width = -1,
		.precision = -1,
		.base = 10,
		};

		struct printf_spec str_spec = spec;
		str_spec.field_width = -1;
		@@ -2024,7 +2018,7 @@ char device_node_string(char buf, char end, struct device_node dn,
		str_spec.precision = precision;
		break;
		case 'p': /* phandle */
		buf = number(buf, end, (unsigned int)dn->phandle, num_spec);
		buf = number(buf, end, (unsigned int)dn->phandle, default_dec_spec);
		break;
		case 'P': /* path-spec */
		p = fwnode_get_name(of_fwnode_handle(dn));

Admin message