Commit 09bb8986 authored by Chen Zhou's avatar Chen Zhou Committed by Christoph Hellwig
Browse files

nvmet: replace kstrndup() with kmemdup_nul() 



It is more efficient to use kmemdup_nul() if the size is known exactly.

The doc in kernel:
"Note: Use kmemdup_nul() instead if the size is known exactly."

Signed-off-by: default avatarChen Zhou <chenzhou10@huawei.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 263c6158

drivers/nvme/target/configfs.c

+2 −2
Original line number Diff line number Diff line
@@ -324,7 +324,7 @@ static ssize_t nvmet_ns_device_path_store(struct config_item *item, 


	kfree(ns->device_path);

	ret = -ENOMEM;

	ns->device_path = kstrndup(page, len, GFP_KERNEL);

	ns->device_path = kmemdup_nul(page, len, GFP_KERNEL);

	if (!ns->device_path)

		goto out_unlock;
@@ -960,7 +960,7 @@ static ssize_t nvmet_subsys_attr_model_store(struct config_item *item, 
			return -EINVAL;

	}



	new_model_number = kstrndup(page, len, GFP_KERNEL);

	new_model_number = kmemdup_nul(page, len, GFP_KERNEL);

	if (!new_model_number)

		return -ENOMEM;

CRA Git | Maintained and supported by SUSTech CRA and CCSE