Commit 0978de9f authored May 11, 2020 by Srinivas Kandagatla Committed by Greg Kroah-Hartman May 15, 2020

misc: fastrpc: Fix an incomplete memory release in fastrpc_rpmsg_probe()



fastrpc_channel_ctx is not freed if misc_register() fails, this would
lead to a memory leak. Fix this leak by adding kfree in misc_register()
error path.

Fixes: 278d56f9 ("misc: fastrpc: Reference count channel context")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20200511162722.2552-1-srinivas.kandagatla@linaro.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 01360857

drivers/misc/fastrpc.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1613,8 +1613,10 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev)
		domains[domain_id]);
		data->miscdev.fops = &fastrpc_fops;
		err = misc_register(&data->miscdev);
		if (err)
		if (err) {
		kfree(data);
		return err;
		}

		kref_init(&data->refcount);

Admin message