Commit 096b110a authored Dec 04, 2015 by Chunfeng Yun Committed by Greg Kroah-Hartman Dec 04, 2015

usb: xhci: fix config fail of FS hub behind a HS hub with MTT



if a full speed hub connects to a high speed hub which
supports MTT, the MTT field of its slot context will be set
to 1 when xHCI driver setups an xHCI virtual device in
xhci_setup_addressable_virt_dev(); once usb core fetch its
hub descriptor, and need to update the xHC's internal data
structures for the device, the HUB field of its slot context
will be set to 1 too, meanwhile MTT is also set before,
this will cause configure endpoint command fail, so in the
case, we should clear MTT to 0 for full speed hub according
to section 6.2.2

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 84ed9152

drivers/usb/host/xhci.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -4778,8 +4778,16 @@ int xhci_update_hub_device(struct usb_hcd hcd, struct usb_device hdev,
		ctrl_ctx->add_flags \|= cpu_to_le32(SLOT_FLAG);
		slot_ctx = xhci_get_slot_ctx(xhci, config_cmd->in_ctx);
		slot_ctx->dev_info \|= cpu_to_le32(DEV_HUB);
		/*
		* refer to section 6.2.2: MTT should be 0 for full speed hub,
		* but it may be already set to 1 when setup an xHCI virtual
		* device, so clear it anyway.
		*/
		if (tt->multi)
		slot_ctx->dev_info \|= cpu_to_le32(DEV_MTT);
		else if (hdev->speed == USB_SPEED_FULL)
		slot_ctx->dev_info &= cpu_to_le32(~DEV_MTT);

		if (xhci->hci_version > 0x95) {
		xhci_dbg(xhci, "xHCI version %x needs hub "
		"TT think time and number of ports\n",

Admin message