edac: core fix workq timer (096846e2) · Commits · 戴 / test

When updating the edac_mc_poll_msec module parameter from the sysfs /sys/module/edac_core/parameters/edac_mc_poll_msec file, we don't update the workq timers. So that, if we move from a big poll time to a small one, the small one won't take effect until the big one has timed out. Here we provide a new module parameter set method to call out to the update routine. This brings the /sys/module/edac_core/parameters functionality up to that provided by the /sys/drivers/system/edac/mc sysfs module parameter files so that we can remove them or at least link to the /sys/module files... Signed-off-by:

Arthur Jones <ajones@riverbed.com> Signed-off-by:

Doug Thompson <dougthompson@xmission.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

drivers/edac/edac_mc_sysfs.c

+21 −1

Original line number	Diff line number	Diff line
		@@ -44,6 +44,25 @@ int edac_mc_get_poll_msec(void)
		return edac_mc_poll_msec;
		}

		static int edac_set_poll_msec(const char val, struct kernel_param kp)
		{
		long l;
		int ret;

		if (!val)
		return -EINVAL;

		ret = strict_strtol(val, 0, &l);
		if (ret == -EINVAL \|\| ((int)l != l))
		return -EINVAL;
		((int )kp->arg) = l;

		/* notify edac_mc engine to reset the poll period */
		edac_mc_reset_delay_period(l);

		return 0;
		}

		/* Parameter declarations for above */
		module_param(edac_mc_panic_on_ue, int, 0644);
		MODULE_PARM_DESC(edac_mc_panic_on_ue, "Panic on uncorrected error: 0=off 1=on");
		@@ -53,7 +72,8 @@ MODULE_PARM_DESC(edac_mc_log_ue,
		module_param(edac_mc_log_ce, int, 0644);
		MODULE_PARM_DESC(edac_mc_log_ce,
		"Log correctable error to console: 0=off 1=on");
		module_param(edac_mc_poll_msec, int, 0644);
		module_param_call(edac_mc_poll_msec, edac_set_poll_msec, param_get_int,
		&edac_mc_poll_msec, 0644);
		MODULE_PARM_DESC(edac_mc_poll_msec, "Polling period in milliseconds");

		/*

Admin message