brcm80211: smac: some local function made static in main.c (094b199b) · Commits · 戴 / test

In main.c a couple of functions were not static although they were only locally used. Sparse gave warnings on them and these functions have been made static. Reviewed-by:

Alwin Beukers <alwin@broadcom.com> Reviewed-by:

Pieter-Paul Giesberts <pieterpg@broadcom.com> Reviewed-by:

Roland Vossen <rvossen@broadcom.com> Signed-off-by:

Arend van Spriel <arend@broadcom.com> Signed-off-by:

John W. Linville <linville@tuxdriver.com>

drivers/net/wireless/brcm80211/brcmsmac/main.c

+5 −6

Original line number	Diff line number	Diff line
		@@ -618,8 +618,7 @@ static void brcms_b_update_slot_timing(struct brcms_hardware *wlc_hw,
		* calculate frame duration of a given rate and length, return
		* time in usec unit
		*/
		uint
		brcms_c_calc_frame_time(struct brcms_c_info *wlc, u32 ratespec,
		static uint brcms_c_calc_frame_time(struct brcms_c_info *wlc, u32 ratespec,
		u8 preamble_type, uint mac_len)
		{
		uint nsyms, dur = 0, Ndps, kNdps;
		@@ -4184,7 +4183,7 @@ void brcms_c_wme_setparams(struct brcms_c_info *wlc, u16 aci,
		}
		}

		void brcms_c_edcf_setparams(struct brcms_c_info *wlc, bool suspend)
		static void brcms_c_edcf_setparams(struct brcms_c_info *wlc, bool suspend)
		{
		u16 aci;
		int i_ac;
		@@ -6100,7 +6099,7 @@ void brcms_c_print_txdesc(struct d11txh *txh)
		#endif /* defined(BCMDBG) */

		#if defined(BCMDBG)
		int
		static int
		brcms_c_format_flags(const struct brcms_c_bit_desc bd, u32 flags, char buf,
		int len)
		{

Admin message