Commit 094919a4 authored by Alexander Duyck's avatar Alexander Duyck Committed by David S. Miller
Browse files

igb: remove rx checksum good counter 



Counting packets with a good checksum can cause a significant amount of cache
line bouncing due to the shared counter being written to by all of the queues.
In order to avoid this I am removing the counter since we still have the
checksum failed counter which will tell us if there are any issues.

Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 047e0030

drivers/net/igb/igb.h

+0 −1
Original line number Diff line number Diff line
@@ -254,7 +254,6 @@ struct igb_adapter { 
	int num_rx_queues;



	u64 hw_csum_err;

	u64 hw_csum_good;

	u32 alloc_rx_buff_failed;

	u32 gorc;

	u64 gorc_old;

drivers/net/igb/igb_ethtool.c

+0 −1
Original line number Diff line number Diff line
@@ -95,7 +95,6 @@ static const struct igb_stats igb_gstrings_stats[] = { 
	{ "tx_flow_control_xon", IGB_STAT(stats.xontxc) },

	{ "tx_flow_control_xoff", IGB_STAT(stats.xofftxc) },

	{ "rx_long_byte_count", IGB_STAT(stats.gorc) },

	{ "rx_csum_offload_good", IGB_STAT(hw_csum_good) },

	{ "rx_csum_offload_errors", IGB_STAT(hw_csum_err) },

	{ "tx_dma_out_of_sync", IGB_STAT(stats.doosync) },

	{ "alloc_rx_buff_failed", IGB_STAT(alloc_rx_buff_failed) },

drivers/net/igb/igb_main.c

+0 −1
Original line number Diff line number Diff line
@@ -4827,7 +4827,6 @@ static inline void igb_rx_checksum_adv(struct igb_adapter *adapter, 
		skb->ip_summed = CHECKSUM_UNNECESSARY;



	dev_dbg(&adapter->pdev->dev, "cksum success: bits %08X\n", status_err);

	adapter->hw_csum_good++;

}



static inline u16 igb_get_hlen(struct igb_adapter *adapter,

CRA Git | Maintained and supported by SUSTech CRA and CCSE