Commit 0946cf1d authored by Russell King's avatar Russell King Committed by David S. Miller
Browse files

net: phylink: only call mac_config() during resolve when link is up 



There's little point calling mac_config() when the link is down.

Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent da203dfa

drivers/net/phy/phylink.c

+9 −2
Original line number Diff line number Diff line
@@ -302,6 +302,13 @@ static void phylink_mac_config(struct phylink *pl, 
	pl->ops->mac_config(pl->netdev, pl->link_an_mode, state);

}



static void phylink_mac_config_up(struct phylink *pl,

				  const struct phylink_link_state *state)

{

	if (state->link)

		phylink_mac_config(pl, state);

}



static void phylink_mac_an_restart(struct phylink *pl)

{

	if (pl->link_config.an_enabled &&
@@ -401,12 +408,12 @@ static void phylink_resolve(struct work_struct *w) 
		case MLO_AN_PHY:

			link_state = pl->phy_state;

			phylink_resolve_flow(pl, &link_state);

			phylink_mac_config(pl, &link_state);

			phylink_mac_config_up(pl, &link_state);

			break;



		case MLO_AN_FIXED:

			phylink_get_fixed_state(pl, &link_state);

			phylink_mac_config(pl, &link_state);

			phylink_mac_config_up(pl, &link_state);

			break;



		case MLO_AN_INBAND:

CRA Git | Maintained and supported by SUSTech CRA and CCSE