Commit 0920c9b4 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Remove beep_mode=2 



The beep_mode=2 option was introduced to make the beep mixer
controlling the beep input allocation/deallocation dynamically, so
that a user can switch between HD-audio codec digital beep and the
system beep only via mixer API.  This was necessary because the
keyboard driver took only the first input beep instance at that time.

However, the recent keyboard driver already processes the multiple
input instances, thus there is no point to keep this mode.

Let's remove it.

Acked-by: default avatarJaroslav Kysela <perex@perex.cz>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 6887a413

Documentation/sound/alsa/ALSA-Configuration.txt

+1 −2
Original line number Diff line number Diff line
@@ -875,8 +875,7 @@ Prior to version 0.9.0rc4 options had a 'snd_' prefix. This was removed. 
    		setup before initializing the codecs.  This option is

		available only when CONFIG_SND_HDA_PATCH_LOADER=y is set.

		See HD-Audio.txt for details.

    beep_mode	- Selects the beep registration mode (0=off, 1=on, 2=

		dynamic registration via mute switch on/off); the default

    beep_mode	- Selects the beep registration mode (0=off, 1=on); default

		value is set via CONFIG_SND_HDA_INPUT_BEEP_MODE kconfig.

    

    [Single (global) options]

sound/pci/hda/Kconfig

+3 −4
Original line number Diff line number Diff line
@@ -53,15 +53,14 @@ config SND_HDA_INPUT_BEEP 
	  driver. This interface is used to generate digital beeps.



config SND_HDA_INPUT_BEEP_MODE

	int "Digital beep registration mode (0=off, 1=on, 2=mute sw on/off)"

	int "Digital beep registration mode (0=off, 1=on)"

	depends on SND_HDA_INPUT_BEEP=y

	default "1"

	range 0 2

	range 0 1

	help

	  Set 0 to disable the digital beep interface for HD-audio by default.

	  Set 1 to always enable the digital beep interface for HD-audio by

	  default. Set 2 to control the beep device registration to input

	  layer using a "Beep Switch" in mixer applications.

	  default.



config SND_HDA_INPUT_JACK

	bool "Support jack plugging notification via input layer"

sound/pci/hda/hda_beep.c

+1 −36
Original line number Diff line number Diff line
@@ -162,28 +162,6 @@ static int snd_hda_do_attach(struct hda_beep *beep) 
	return 0;

}



static void snd_hda_do_register(struct work_struct *work)

{

	struct hda_beep *beep =

		container_of(work, struct hda_beep, register_work);



	mutex_lock(&beep->mutex);

	if (beep->enabled && !beep->dev)

		snd_hda_do_attach(beep);

	mutex_unlock(&beep->mutex);

}



static void snd_hda_do_unregister(struct work_struct *work)

{

	struct hda_beep *beep =

		container_of(work, struct hda_beep, unregister_work.work);



	mutex_lock(&beep->mutex);

	if (!beep->enabled && beep->dev)

		snd_hda_do_detach(beep);

	mutex_unlock(&beep->mutex);

}



int snd_hda_enable_beep_device(struct hda_codec *codec, int enable)

{

	struct hda_beep *beep = codec->beep;
@@ -197,15 +175,6 @@ int snd_hda_enable_beep_device(struct hda_codec *codec, int enable) 
			snd_hda_codec_write(beep->codec, beep->nid, 0,

						  AC_VERB_SET_BEEP_CONTROL, 0);

		}

		if (beep->mode == HDA_BEEP_MODE_SWREG) {

			if (enable) {

				cancel_delayed_work(&beep->unregister_work);

				schedule_work(&beep->register_work);

			} else {

				schedule_delayed_work(&beep->unregister_work,

									   HZ);

			}

		}

		return 1;

	}

	return 0;
@@ -235,12 +204,10 @@ int snd_hda_attach_beep_device(struct hda_codec *codec, int nid) 
	beep->mode = codec->beep_mode;

	codec->beep = beep;



	INIT_WORK(&beep->register_work, &snd_hda_do_register);

	INIT_DELAYED_WORK(&beep->unregister_work, &snd_hda_do_unregister);

	INIT_WORK(&beep->beep_work, &snd_hda_generate_beep);

	mutex_init(&beep->mutex);



	if (beep->mode == HDA_BEEP_MODE_ON) {

	if (beep->mode) {

		int err = snd_hda_do_attach(beep);

		if (err < 0) {

			kfree(beep);
@@ -257,8 +224,6 @@ void snd_hda_detach_beep_device(struct hda_codec *codec) 
{

	struct hda_beep *beep = codec->beep;

	if (beep) {

		cancel_work_sync(&beep->register_work);

		cancel_delayed_work(&beep->unregister_work);

		if (beep->dev)

			snd_hda_do_detach(beep);

		codec->beep = NULL;

sound/pci/hda/hda_beep.h

+0 −4
Original line number Diff line number Diff line
@@ -26,7 +26,6 @@ 


#define HDA_BEEP_MODE_OFF	0

#define HDA_BEEP_MODE_ON	1

#define HDA_BEEP_MODE_SWREG	2



/* beep information */

struct hda_beep {
@@ -37,10 +36,7 @@ struct hda_beep { 
	int tone;

	hda_nid_t nid;

	unsigned int enabled:1;

	unsigned int request_enable:1;

	unsigned int linear_tone:1;	/* linear tone for IDT/STAC codec */

	struct work_struct register_work; /* registration work */

	struct delayed_work unregister_work; /* unregistration work */

	struct work_struct beep_work; /* scheduled task for beep event */

	struct mutex mutex;

};

sound/pci/hda/hda_intel.c

+3 −3
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ static int enable_msi = -1; 
static char *patch[SNDRV_CARDS];

#endif

#ifdef CONFIG_SND_HDA_INPUT_BEEP

static int beep_mode[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS-1)] =

static bool beep_mode[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS-1)] =

					CONFIG_SND_HDA_INPUT_BEEP_MODE};

#endif
@@ -103,9 +103,9 @@ module_param_array(patch, charp, NULL, 0444); 
MODULE_PARM_DESC(patch, "Patch file for Intel HD audio interface.");

#endif

#ifdef CONFIG_SND_HDA_INPUT_BEEP

module_param_array(beep_mode, int, NULL, 0444);

module_param_array(beep_mode, bool, NULL, 0444);

MODULE_PARM_DESC(beep_mode, "Select HDA Beep registration mode "

			    "(0=off, 1=on, 2=mute switch on/off) (default=1).");

			    "(0=off, 1=on) (default=1).");

#endif



#ifdef CONFIG_SND_HDA_POWER_SAVE

CRA Git | Maintained and supported by SUSTech CRA and CCSE