Revert "io_uring: mark io_uring_fops/io_op_defs as __read_mostly" (0918682b) · Commits · 戴 / test

This reverts commit . This change didn't make a lot of sense, and as Linus reports, it actually fails on clang: /tmp/io_uring-dd40c4.s:26476: Warning: ignoring changed section attributes for .data..read_mostly The arrays are already marked const so, by definition, they are not just read-mostly, they are read-only. Reported-by:

Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by:

Jens Axboe <axboe@kernel.dk>

fs/io_uring.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -760,7 +760,7 @@ struct io_op_def {
		unsigned short async_size;
		};

		static const struct io_op_def io_op_defs[] __read_mostly = {
		static const struct io_op_def io_op_defs[] = {
		[IORING_OP_NOP] = {},
		[IORING_OP_READV] = {
		.needs_mm = 1,
		@@ -983,7 +983,7 @@ static int io_setup_async_rw(struct io_kiocb req, const struct iovec iovec,

		static struct kmem_cache *req_cachep;

		static const struct file_operations io_uring_fops __read_mostly;
		static const struct file_operations io_uring_fops;

		struct sock io_uring_get_socket(struct file file)
		{

Admin message