Commit 090abf7b authored Jul 27, 2012 by Jaeden Amero Committed by Greg Kroah-Hartman Aug 10, 2012

n_tty: Don't lose characters when PARMRK is enabled



When PARMRK is set and large transfers of characters that will get
marked are being received, n_tty could drop data silently (i.e.
without reporting any error to the client). This is because
characters have the potential to take up to three bytes in the line
discipline (when they get marked with parity or framing errors), but
the amount of free space reported to tty_buffer flush_to_ldisc (via
tty->receive_room) is based on the pre-marked data size.

With this patch, the n_tty layer will no longer assume that each byte
will only take up one byte in the line discipline. Instead, it will
make an overly conservative estimate that each byte will take up
three bytes in the line discipline when PARMRK is set.

Signed-off-by: Jaeden Amero <jaeden.amero@ni.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 00aaae03

drivers/tty/n_tty.c

+10 −2

Original line number	Diff line number	Diff line
		@@ -92,10 +92,18 @@ static inline int tty_put_user(struct tty_struct *tty, unsigned char x,

		static void n_tty_set_room(struct tty_struct *tty)
		{
		/* tty->read_cnt is not read locked ? */
		int left = N_TTY_BUF_SIZE - tty->read_cnt - 1;
		int left;
		int old_left;

		/* tty->read_cnt is not read locked ? */
		if (I_PARMRK(tty)) {
		/* Multiply read_cnt by 3, since each byte might take up to
		* three times as many spaces when PARMRK is set (depending on
		* its flags, e.g. parity error). */
		left = N_TTY_BUF_SIZE - tty->read_cnt * 3 - 1;
		} else
		left = N_TTY_BUF_SIZE - tty->read_cnt - 1;

		/*
		* If we are doing input canonicalization, and there are no
		* pending newlines, let characters through without limit, so

Admin message