[PATCH] ext3 filesystem bogus ENOSPC with reservation fix (08fb306f) · Commits · 戴 / test

To handle the earlier bogus ENOSPC error caused by filesystem full of block reservation, current code falls back to non block reservation, starts to allocate block(s) from the goal allocation block group as if there is no block reservation. Current code needs to re-load the corresponding block group descriptor for the initial goal block group in this case. The patch fixes this. Signed-off-by:

Mingming Cao <cmm@us.ibm.com> Signed-off-by:

Andrew Morton <akpm@osdl.org> Signed-off-by:

Linus Torvalds <torvalds@osdl.org>

fs/ext3/balloc.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1269,12 +1269,12 @@ ext3_fsblk_t ext3_new_blocks(handle_t handle, struct inode inode,
		goal = le32_to_cpu(es->s_first_data_block);
		group_no = (goal - le32_to_cpu(es->s_first_data_block)) /
		EXT3_BLOCKS_PER_GROUP(sb);
		goal_group = group_no;
		retry_alloc:
		gdp = ext3_get_group_desc(sb, group_no, &gdp_bh);
		if (!gdp)
		goto io_error;

		goal_group = group_no;
		retry:
		free_blocks = le16_to_cpu(gdp->bg_free_blocks_count);
		/*
		* if there is not enough free blocks to make a new resevation
		@@ -1349,7 +1349,7 @@ retry:
		if (my_rsv) {
		my_rsv = NULL;
		group_no = goal_group;
		goto retry;
		goto retry_alloc;
		}
		/* No space left on the device */
		*errp = -ENOSPC;

Admin message