Commit 08f503b0 authored Mar 10, 2008 by Gregory Haskins Committed by Ingo Molnar Mar 11, 2008

keep rd->online and cpu_online_map in sync



It is possible to allow the root-domain cache of online cpus to
become out of sync with the global cpu_online_map.  This is because we
currently trigger removal of cpus too early in the notifier chain.
Other DOWN_PREPARE handlers may in fact run and reconfigure the
root-domain topology, thereby stomping on our own offline handling.

The end result is that rd->online may become out of sync with
cpu_online_map, which results in potential task misrouting.

So change the offline handling to be more tightly coupled with the
global offline process by triggering on CPU_DYING intead of
CPU_DOWN_PREPARE.

Signed-off-by: Gregory Haskins <ghaskins@novell.com>
Cc: Gautham R Shenoy <ego@in.ibm.com>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 1f94ef59

kernel/sched.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -5881,7 +5881,8 @@ migration_call(struct notifier_block nfb, unsigned long action, void hcpu)
		spin_unlock_irq(&rq->lock);
		break;

		case CPU_DOWN_PREPARE:
		case CPU_DYING:
		case CPU_DYING_FROZEN:
		/* Update our root-domain */
		rq = cpu_rq(cpu);
		spin_lock_irqsave(&rq->lock, flags);

Admin message