Commit 08edaaa6 authored Jul 03, 2018 by Anna-Maria Gleixner Committed by Shaohua Li Jul 23, 2018

drivers/md/raid5: Do not disable irq on release_inactive_stripe_list() call



There is no need to invoke release_inactive_stripe_list() with interrupts
disabled. All call sites, except raid5_release_stripe(), unlock
->device_lock and enable interrupts before invoking the function.

Make it consistent.

Cc: Shaohua Li <shli@kernel.org>
Cc: linux-raid@vger.kernel.org
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Shaohua Li <shli@fb.com>

parent 685dbcaa

drivers/md/raid5.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -414,9 +414,8 @@ slow_path:
	INIT_LIST_HEAD(&list);		INIT_LIST_HEAD(&list);
	hash = sh->hash_lock_index;		hash = sh->hash_lock_index;
	do_release_stripe(conf, sh, &list);		do_release_stripe(conf, sh, &list);
	spin_unlock(&conf->device_lock);		spin_unlock_irqrestore(&conf->device_lock, flags);
	release_inactive_stripe_list(conf, &list, hash);		release_inactive_stripe_list(conf, &list, hash);
	local_irq_restore(flags);
	}		}
	}		}

Admin message