Commit 08ec1e62 authored Jun 28, 2019 by Coly Li Committed by Jens Axboe Jun 28, 2019

bcache: add io error counting in write_bdev_super_endio()



When backing device super block is written by bch_write_bdev_super(),
the bio complete callback write_bdev_super_endio() simply ignores I/O
status. Indeed such write request also contribute to backing device
health status if the request failed.

This patch checkes bio->bi_status in write_bdev_super_endio(), if there
is error, bch_count_backing_io_errors() will be called to count an I/O
error to dc->io_errors.

Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 578df99b

drivers/md/bcache/super.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -197,7 +197,9 @@ err:
		static void write_bdev_super_endio(struct bio *bio)
		{
		struct cached_dev *dc = bio->bi_private;
		/* XXX: error checking */

		if (bio->bi_status)
		bch_count_backing_io_errors(dc, bio);

		closure_put(&dc->sb_write);
		}

Admin message