Commit 08e18eab authored by Josef Bacik's avatar Josef Bacik Committed by Jens Axboe
Browse files

block: add bi_blkg to the bio for cgroups 



Currently io.low uses a bi_cg_private to stash its private data for the
blkg, however other blkcg policies may want to use this as well.  Since
we can get the private data out of the blkg, move this to bi_blkg in the
bio and make it generic, then we can use bio_associate_blkg() to attach
the blkg to the bio.

Theoretically we could simply replace the bi_css with this since we can
get to all the same information from the blkg, however you have to
lookup the blkg, so for example wbc_init_bio() would have to lookup and
possibly allocate the blkg for the css it was trying to attach to the
bio.  This could be problematic and result in us either not attaching
the css at all to the bio, or falling back to the root blkcg if we are
unable to allocate the corresponding blkg.

So for now do this, and in the future if possible we could just replace
the bi_css with bi_blkg and update the helpers to do the correct
translation.

Signed-off-by: default avatarJosef Bacik <jbacik@fb.com>
Acked-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 6e768717

block/bio.c

+23 −0
Original line number Diff line number Diff line
@@ -28,6 +28,7 @@ 
#include <linux/mempool.h>

#include <linux/workqueue.h>

#include <linux/cgroup.h>

#include <linux/blk-cgroup.h>



#include <trace/events/block.h>

#include "blk.h"
@@ -2036,6 +2037,24 @@ int bio_associate_blkcg(struct bio *bio, struct cgroup_subsys_state *blkcg_css) 
}

EXPORT_SYMBOL_GPL(bio_associate_blkcg);



/**

 * bio_associate_blkg - associate a bio with the specified blkg

 * @bio: target bio

 * @blkg: the blkg to associate

 *

 * Associate @bio with the blkg specified by @blkg.  This is the queue specific

 * blkcg information associated with the @bio, a reference will be taken on the

 * @blkg and will be freed when the bio is freed.

 */

int bio_associate_blkg(struct bio *bio, struct blkcg_gq *blkg)

{

	if (unlikely(bio->bi_blkg))

		return -EBUSY;

	blkg_get(blkg);

	bio->bi_blkg = blkg;

	return 0;

}



/**

 * bio_disassociate_task - undo bio_associate_current()

 * @bio: target bio
@@ -2050,6 +2069,10 @@ void bio_disassociate_task(struct bio *bio) 
		css_put(bio->bi_css);

		bio->bi_css = NULL;

	}

	if (bio->bi_blkg) {

		blkg_put(bio->bi_blkg);

		bio->bi_blkg = NULL;

	}

}



/**

block/blk-throttle.c

+7 −14
Original line number Diff line number Diff line
@@ -2134,12 +2134,8 @@ static inline void throtl_update_latency_buckets(struct throtl_data *td) 
static void blk_throtl_assoc_bio(struct throtl_grp *tg, struct bio *bio)

{

#ifdef CONFIG_BLK_DEV_THROTTLING_LOW

	if (bio->bi_css) {

		if (bio->bi_cg_private)

			blkg_put(tg_to_blkg(bio->bi_cg_private));

		bio->bi_cg_private = tg;

		blkg_get(tg_to_blkg(tg));

	}

	if (bio->bi_css)

		bio_associate_blkg(bio, tg_to_blkg(tg));

	bio_issue_init(&bio->bi_issue, bio_sectors(bio));

#endif

}
@@ -2287,6 +2283,7 @@ void blk_throtl_stat_add(struct request *rq, u64 time_ns) 


void blk_throtl_bio_endio(struct bio *bio)

{

	struct blkcg_gq *blkg;

	struct throtl_grp *tg;

	u64 finish_time_ns;

	unsigned long finish_time;
@@ -2294,20 +2291,18 @@ void blk_throtl_bio_endio(struct bio *bio) 
	unsigned long lat;

	int rw = bio_data_dir(bio);



	tg = bio->bi_cg_private;

	if (!tg)

	blkg = bio->bi_blkg;

	if (!blkg)

		return;

	bio->bi_cg_private = NULL;

	tg = blkg_to_tg(blkg);



	finish_time_ns = ktime_get_ns();

	tg->last_finish_time = finish_time_ns >> 10;



	start_time = bio_issue_time(&bio->bi_issue) >> 10;

	finish_time = __bio_issue_time(finish_time_ns) >> 10;

	if (!start_time || finish_time <= start_time) {

		blkg_put(tg_to_blkg(tg));

	if (!start_time || finish_time <= start_time)

		return;

	}



	lat = finish_time - start_time;

	/* this is only for bio based driver */
@@ -2336,8 +2331,6 @@ void blk_throtl_bio_endio(struct bio *bio) 
		tg->bio_cnt /= 2;

		tg->bad_bio_cnt /= 2;

	}



	blkg_put(tg_to_blkg(tg));

}

#endif

include/linux/bio.h

+1 −0
Original line number Diff line number Diff line
@@ -555,6 +555,7 @@ do { \ 


#ifdef CONFIG_BLK_CGROUP

int bio_associate_blkcg(struct bio *bio, struct cgroup_subsys_state *blkcg_css);

int bio_associate_blkg(struct bio *bio, struct blkcg_gq *blkg);

void bio_disassociate_task(struct bio *bio);

void bio_clone_blkcg_association(struct bio *dst, struct bio *src);

#else	/* CONFIG_BLK_CGROUP */

include/linux/blk_types.h

+1 −1
Original line number Diff line number Diff line
@@ -179,8 +179,8 @@ struct bio { 
	 */

	struct io_context	*bi_ioc;

	struct cgroup_subsys_state *bi_css;

	struct blkcg_gq		*bi_blkg;

#ifdef CONFIG_BLK_DEV_THROTTLING_LOW

	void			*bi_cg_private;

	struct bio_issue	bi_issue;

#endif

#endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE