Commit 08d9ae7c authored Jun 16, 2009 by Wu Fengguang Committed by Linus Torvalds Jun 16, 2009

vmscan: don't export nr_saved_scan in /proc/zoneinfo



The lru->nr_saved_scan's are not meaningful counters for even kernel
developers.  They typically are smaller than 32 and are always 0 for large
lists.  So remove them from /proc/zoneinfo.

Hopefully this interface change won't break too many scripts.
/proc/zoneinfo is too unstructured to be script friendly, and I wonder the
affected scripts - if there are any - are still bleeding since the not
long ago commit "vmscan: split LRU lists into anon & file sets", which
also touched the "scanned" line :)

If we are to re-export accumulated vmscan counts in the future, they can
go to new lines in /proc/zoneinfo instead of the current form, or to
/sys/devices/system/node/node0/meminfo?

Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>

Acked-by: Rik van Riel <riel@redhat.com>
Cc: Nick Piggin <npiggin@suse.de>
Acked-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 6e08a369

mm/vmstat.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -710,7 +710,7 @@ static void zoneinfo_show_print(struct seq_file m, pg_data_t pgdat,
		"\n min %lu"
		"\n low %lu"
		"\n high %lu"
		"\n scanned %lu (aa: %lu ia: %lu af: %lu if: %lu)"
		"\n scanned %lu"
		"\n spanned %lu"
		"\n present %lu",
		zone_page_state(zone, NR_FREE_PAGES),
		@@ -718,10 +718,6 @@ static void zoneinfo_show_print(struct seq_file m, pg_data_t pgdat,
		low_wmark_pages(zone),
		high_wmark_pages(zone),
		zone->pages_scanned,
		zone->lru[LRU_ACTIVE_ANON].nr_saved_scan,
		zone->lru[LRU_INACTIVE_ANON].nr_saved_scan,
		zone->lru[LRU_ACTIVE_FILE].nr_saved_scan,
		zone->lru[LRU_INACTIVE_FILE].nr_saved_scan,
		zone->spanned_pages,
		zone->present_pages);

Admin message