Commit 08cc0f44 authored Dec 12, 2019 by Colin Ian King Committed by Kalle Valo Dec 18, 2019

ath11k: fix uninitialized variable radioup



The variable radioup is not uninitalized so it may contain a garbage
value and hence the detection of a radio that is not up is buggy.
Fix this by initializing it to zero.

Addresses-Coverity: ("Uninitalized scalar variable")
Fixes: d5c65159 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent b5316db2

drivers/net/wireless/ath/ath11k/debug.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -541,7 +541,7 @@ static ssize_t ath11k_write_simulate_fw_crash(struct file *file,
		struct ath11k *ar = ab->pdevs[0].ar;
		char buf[32] = {0};
		ssize_t rc;
		int i, ret, radioup;
		int i, ret, radioup = 0;

		for (i = 0; i < ab->num_radios; i++) {
		pdev = &ab->pdevs[i];

Admin message