Commit 08cb3f60 authored Nov 04, 2009 by Dan Carpenter Committed by David S. Miller Nov 04, 2009

misdn: Fix reversed 'if' in st_own_ctrl

The current code probably returns -EINVAL a lot.  Otherwise it would oops.

Compile tested only.  Found by smatch (http://repo.or.cz/w/smatch.git

).

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Karsten Keil <isdn@linux-pingi.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 02303d20

drivers/isdn/mISDN/stack.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -364,7 +364,7 @@ add_layer2(struct mISDNchannel ch, struct mISDNstack st)
		static int
		st_own_ctrl(struct mISDNchannel ch, u_int cmd, void arg)
		{
		if (!ch->st \|\| ch->st->layer1)
		if (!ch->st \|\| !ch->st->layer1)
		return -EINVAL;
		return ch->st->layer1->ctrl(ch->st->layer1, cmd, arg);
		}

Admin message