Commit 08c96543 authored by Jose Abreu's avatar Jose Abreu Committed by David S. Miller
Browse files

net: stmmac: selftests: Needs to check the number of Multicast regs 



When running the MC and UC filter tests we setup a multicast address
that its expected to be blocked. If the number of available multicast
registers is zero, driver will always pass the multicast packets which
will fail the test.

Check if available multicast addresses is enough before running the
tests.

Fixes: 091810db ("net: stmmac: Introduce selftests support")
Signed-off-by: default avatarJose Abreu <Jose.Abreu@synopsys.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b7ac8936

drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c

+4 −0
Original line number Diff line number Diff line
@@ -624,6 +624,8 @@ static int stmmac_test_mcfilt(struct stmmac_priv *priv) 
		return -EOPNOTSUPP;

	if (netdev_uc_count(priv->dev) >= priv->hw->unicast_filter_entries)

		return -EOPNOTSUPP;

	if (netdev_mc_count(priv->dev) >= priv->hw->multicast_filter_bins)

		return -EOPNOTSUPP;



	while (--tries) {

		/* We only need to check the mc_addr for collisions */
@@ -666,6 +668,8 @@ static int stmmac_test_ucfilt(struct stmmac_priv *priv) 


	if (stmmac_filter_check(priv))

		return -EOPNOTSUPP;

	if (netdev_uc_count(priv->dev) >= priv->hw->unicast_filter_entries)

		return -EOPNOTSUPP;

	if (netdev_mc_count(priv->dev) >= priv->hw->multicast_filter_bins)

		return -EOPNOTSUPP;

CRA Git | Maintained and supported by SUSTech CRA and CCSE