Commit 08acc963 authored May 31, 2020 by Christophe JAILLET Committed by Linus Walleij Jun 04, 2020

pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken



Commit 6d33ee7a ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration")
has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in
'pxa2xx_pinctrl_init()'.
However, the corresponding 'pinctrl_unregister()' call in
'pxa2xx_pinctrl_exit()' has not been removed.

This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused.
Remove it now to avoid some wondering in the future and save a few LoC.

Fixes: 6d33ee7a ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Link: https://lore.kernel.org/r/20200531073716.593343-1-christophe.jaillet@wanadoo.fr


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent ba403242

drivers/pinctrl/pxa/pinctrl-pxa2xx.c

+0 −9

Original line number	Diff line number	Diff line
		@@ -425,15 +425,6 @@ int pxa2xx_pinctrl_init(struct platform_device *pdev,
		}
		EXPORT_SYMBOL_GPL(pxa2xx_pinctrl_init);

		int pxa2xx_pinctrl_exit(struct platform_device *pdev)
		{
		struct pxa_pinctrl *pctl = platform_get_drvdata(pdev);

		pinctrl_unregister(pctl->pctl_dev);
		return 0;
		}
		EXPORT_SYMBOL_GPL(pxa2xx_pinctrl_exit);

		MODULE_AUTHOR("Robert Jarzmik <robert.jarzmik@free.fr>");
		MODULE_DESCRIPTION("Marvell PXA2xx pinctrl driver");
		MODULE_LICENSE("GPL v2");

Admin message