Commit 089ef557 authored Apr 20, 2020 by Dmitry Safonov Committed by Thomas Gleixner Apr 21, 2020

x86/vdso/vdso2c: Correct error messages on file open



err() message in main() is misleading: it should print `outfilename`,
which is argv[3], not argv[2].

Correct error messages to be more precise about what failed and for
which file.

Co-developed-by: Andrei Vagin <avagin@openvz.org>
Signed-off-by: Andrei Vagin <avagin@openvz.org>
Signed-off-by: Dmitry Safonov <dima@arista.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Andy Lutomirski <luto@kernel.org>
Link: https://lkml.kernel.org/r/20200420183256.660371-2-dima@arista.com

parent ae83d0b4

arch/x86/entry/vdso/vdso2c.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -187,7 +187,7 @@ static void map_input(const char name, void addr, size_t len, int prot)

		int fd = open(name, O_RDONLY);
		if (fd == -1)
		err(1, "%s", name);
		err(1, "open(%s)", name);

		tmp_len = lseek(fd, 0, SEEK_END);
		if (tmp_len == (off_t)-1)
		@@ -240,7 +240,7 @@ int main(int argc, char **argv)
		outfilename = argv[3];
		outfile = fopen(outfilename, "w");
		if (!outfile)
		err(1, "%s", argv[2]);
		err(1, "fopen(%s)", outfilename);

		go(raw_addr, raw_len, stripped_addr, stripped_len, outfile, name);

Admin message