Commit 088e9d25 authored by Daniel Bristot de Oliveira's avatar Daniel Bristot de Oliveira Committed by Paul E. McKenney
Browse files

rcu: sysctl: Panic on RCU Stall 



It is not always easy to determine the cause of an RCU stall just by
analysing the RCU stall messages, mainly when the problem is caused
by the indirect starvation of rcu threads. For example, when preempt_rcu
is not awakened due to the starvation of a timer softirq.

We have been hard coding panic() in the RCU stall functions for
some time while testing the kernel-rt. But this is not possible in
some scenarios, like when supporting customers.

This patch implements the sysctl kernel.panic_on_rcu_stall. If
set to 1, the system will panic() when an RCU stall takes place,
enabling the capture of a vmcore. The vmcore provides a way to analyze
all kernel/tasks states, helping out to point to the culprit and the
solution for the stall.

The kernel.panic_on_rcu_stall sysctl is disabled by default.

Changes from v1:
- Fixed a typo in the git log
- The if(sysctl_panic_on_rcu_stall) panic() is in a static function
- Fixed the CONFIG_TINY_RCU compilation issue
- The var sysctl_panic_on_rcu_stall is now __read_mostly

Cc: Jonathan Corbet <corbet@lwn.net>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Acked-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: default avatarJosh Triplett <josh@joshtriplett.org>
Reviewed-by: default avatarArnaldo Carvalho de Melo <acme@kernel.org>
Tested-by: default avatar"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
Signed-off-by: default avatarDaniel Bristot de Oliveira <bristot@redhat.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent aab05738

Documentation/sysctl/kernel.txt

+12 −0
Original line number Diff line number Diff line
@@ -58,6 +58,7 @@ show up in /proc/sys/kernel: 
- panic_on_stackoverflow

- panic_on_unrecovered_nmi

- panic_on_warn

- panic_on_rcu_stall

- perf_cpu_time_max_percent

- perf_event_paranoid

- perf_event_max_stack
@@ -618,6 +619,17 @@ a kernel rebuild when attempting to kdump at the location of a WARN(). 


==============================================================



panic_on_rcu_stall:



When set to 1, calls panic() after RCU stall detection messages. This

is useful to define the root cause of RCU stalls using a vmcore.



0: do not panic() when RCU stall takes place, default behavior.



1: panic() after printing RCU stall messages.



==============================================================



perf_cpu_time_max_percent:



Hints to the kernel how much CPU time it should be allowed to

include/linux/kernel.h

+1 −0
Original line number Diff line number Diff line
@@ -451,6 +451,7 @@ extern int panic_on_oops; 
extern int panic_on_unrecovered_nmi;

extern int panic_on_io_nmi;

extern int panic_on_warn;

extern int sysctl_panic_on_rcu_stall;

extern int sysctl_panic_on_stackoverflow;



extern bool crash_kexec_post_notifiers;

kernel/rcu/tree.c

+12 −0
Original line number Diff line number Diff line
@@ -125,6 +125,8 @@ int rcu_num_lvls __read_mostly = RCU_NUM_LVLS; 
/* Number of rcu_nodes at specified level. */

static int num_rcu_lvl[] = NUM_RCU_LVL_INIT;

int rcu_num_nodes __read_mostly = NUM_RCU_NODES; /* Total # rcu_nodes in use. */

/* panic() on RCU Stall sysctl. */

int sysctl_panic_on_rcu_stall __read_mostly;



/*

 * The rcu_scheduler_active variable transitions from zero to one just
@@ -1312,6 +1314,12 @@ static void rcu_stall_kick_kthreads(struct rcu_state *rsp) 
	}

}



static inline void panic_on_rcu_stall(void)

{

	if (sysctl_panic_on_rcu_stall)

		panic("RCU Stall\n");

}



static void print_other_cpu_stall(struct rcu_state *rsp, unsigned long gpnum)

{

	int cpu;
@@ -1391,6 +1399,8 @@ static void print_other_cpu_stall(struct rcu_state *rsp, unsigned long gpnum) 


	rcu_check_gp_kthread_starvation(rsp);



	panic_on_rcu_stall();



	force_quiescent_state(rsp);  /* Kick them all. */

}
@@ -1431,6 +1441,8 @@ static void print_cpu_stall(struct rcu_state *rsp) 
			   jiffies + 3 * rcu_jiffies_till_stall_check() + 3);

	raw_spin_unlock_irqrestore_rcu_node(rnp, flags);



	panic_on_rcu_stall();



	/*

	 * Attempt to revive the RCU machinery by forcing a context switch.

	 *

kernel/sysctl.c

+11 −0
Original line number Diff line number Diff line
@@ -1204,6 +1204,17 @@ static struct ctl_table kern_table[] = { 
		.extra1		= &one,

		.extra2		= &one,

	},

#endif

#if defined(CONFIG_TREE_RCU) || defined(CONFIG_PREEMPT_RCU)

	{

		.procname	= "panic_on_rcu_stall",

		.data		= &sysctl_panic_on_rcu_stall,

		.maxlen		= sizeof(sysctl_panic_on_rcu_stall),

		.mode		= 0644,

		.proc_handler	= proc_dointvec_minmax,

		.extra1		= &zero,

		.extra2		= &one,

	},

#endif

	{ }

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE