Commit 086f9f3d authored by Stefano Sanfilippo's avatar Stefano Sanfilippo Committed by Arnaldo Carvalho de Melo
Browse files

perf jit: Generate .eh_frame/.eh_frame_hdr in DSO 



When the jit_buf_desc contains unwinding information, it is emitted as
eh_frame unwinding sections in the DSOs generated by perf inject.

The unwinding information is required to unwind of JITed code which do
not maintain the frame pointer register during function calls.  It can
be emitted by V8 / Chromium when the --perf_prof_unwinding_info is
passed to V8.

The eh_frame and eh_frame_hdr sections are emitted immediately after the
.text.

The .eh_frame is aligned at a 8-byte boundary, and .eh_frame_hdr at a
4-byte one. Since size of the .eh_frame is required to be a multiple of
the word size, which means there will never be additional padding
between it and the .eh_frame_hdr on machines where the word size is 4 or
8 bytes.

However, additional padding might be inserted between .text and
.eh_frame to reach the correct alignment, which will always be 8 bytes,
also on 32bit machines. The reasoning behind this choice is that 4 extra
bytes of padding worst case are not a large cost for the advantage of
removing word-size dependent offset calculations when emitting the
jitdump.

Signed-off-by: default avatarStefano Sanfilippo <ssanfilippo@chromium.org>
Signed-off-by: default avatarRoss McIlroy <rmcilroy@chromium.org>
Reviewed-by: default avatarStephane Eranian <eranian@google.com>
Cc: Anton Blanchard <anton@ozlabs.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1476356383-30100-8-git-send-email-eranian@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 0284fecd

tools/perf/util/genelf.c

+99 −3
Original line number Diff line number Diff line
@@ -73,6 +73,8 @@ static char shd_string_table[] = { 
	'.', 'd', 'e', 'b', 'u', 'g', '_', 'l', 'i', 'n', 'e', 0, /* 52 */

	'.', 'd', 'e', 'b', 'u', 'g', '_', 'i', 'n', 'f', 'o', 0, /* 64 */

	'.', 'd', 'e', 'b', 'u', 'g', '_', 'a', 'b', 'b', 'r', 'e', 'v', 0, /* 76 */

	'.', 'e', 'h', '_', 'f', 'r', 'a', 'm', 'e', '_', 'h', 'd', 'r', 0, /* 90 */

	'.', 'e', 'h', '_', 'f', 'r', 'a', 'm', 'e', 0, /* 104 */

};



static struct buildid_note {
@@ -153,6 +155,86 @@ gen_build_id(struct buildid_note *note, unsigned long load_addr, const void *cod 
}

#endif



static int

jit_add_eh_frame_info(Elf *e, void* unwinding, uint64_t unwinding_header_size,

		      uint64_t unwinding_size, uint64_t base_offset)

{

	Elf_Data *d;

	Elf_Scn *scn;

	Elf_Shdr *shdr;

	uint64_t unwinding_table_size = unwinding_size - unwinding_header_size;



	/*

	 * setup eh_frame section

	 */

	scn = elf_newscn(e);

	if (!scn) {

		warnx("cannot create section");

		return -1;

	}



	d = elf_newdata(scn);

	if (!d) {

		warnx("cannot get new data");

		return -1;

	}



	d->d_align = 8;

	d->d_off = 0LL;

	d->d_buf = unwinding;

	d->d_type = ELF_T_BYTE;

	d->d_size = unwinding_table_size;

	d->d_version = EV_CURRENT;



	shdr = elf_getshdr(scn);

	if (!shdr) {

		warnx("cannot get section header");

		return -1;

	}



	shdr->sh_name = 104;

	shdr->sh_type = SHT_PROGBITS;

	shdr->sh_addr = base_offset;

	shdr->sh_flags = SHF_ALLOC;

	shdr->sh_entsize = 0;



	/*

	 * setup eh_frame_hdr section

	 */

	scn = elf_newscn(e);

	if (!scn) {

		warnx("cannot create section");

		return -1;

	}



	d = elf_newdata(scn);

	if (!d) {

		warnx("cannot get new data");

		return -1;

	}



	d->d_align = 4;

	d->d_off = 0LL;

	d->d_buf = unwinding + unwinding_table_size;

	d->d_type = ELF_T_BYTE;

	d->d_size = unwinding_header_size;

	d->d_version = EV_CURRENT;



	shdr = elf_getshdr(scn);

	if (!shdr) {

		warnx("cannot get section header");

		return -1;

	}



	shdr->sh_name = 90;

	shdr->sh_type = SHT_PROGBITS;

	shdr->sh_addr = base_offset + unwinding_table_size;

	shdr->sh_flags = SHF_ALLOC;

	shdr->sh_entsize = 0;



	return 0;

}



/*

 * fd: file descriptor open for writing for the output file

 * load_addr: code load address (could be zero, just used for buildid)
@@ -163,13 +245,15 @@ gen_build_id(struct buildid_note *note, unsigned long load_addr, const void *cod 
int

jit_write_elf(int fd, uint64_t load_addr, const char *sym,

	      const void *code, int csize,

	      void *debug __maybe_unused, int nr_debug_entries __maybe_unused)

	      void *debug __maybe_unused, int nr_debug_entries __maybe_unused,

	      void *unwinding, uint64_t unwinding_header_size, uint64_t unwinding_size)

{

	Elf *e;

	Elf_Data *d;

	Elf_Scn *scn;

	Elf_Ehdr *ehdr;

	Elf_Shdr *shdr;

	uint64_t eh_frame_base_offset;

	char *strsym = NULL;

	int symlen;

	int retval = -1;
@@ -200,7 +284,7 @@ jit_write_elf(int fd, uint64_t load_addr, const char *sym, 
	ehdr->e_type = ET_DYN;

	ehdr->e_entry = GEN_ELF_TEXT_OFFSET;

	ehdr->e_version = EV_CURRENT;

	ehdr->e_shstrndx= 2; /* shdr index for section name */

	ehdr->e_shstrndx= unwinding ? 4 : 2; /* shdr index for section name */



	/*

	 * setup text section
@@ -236,6 +320,18 @@ jit_write_elf(int fd, uint64_t load_addr, const char *sym, 
	shdr->sh_flags = SHF_EXECINSTR | SHF_ALLOC;

	shdr->sh_entsize = 0;



	/*

	 * Setup .eh_frame_hdr and .eh_frame

	 */

	if (unwinding) {

		eh_frame_base_offset = ALIGN_8(GEN_ELF_TEXT_OFFSET + csize);

		retval = jit_add_eh_frame_info(e, unwinding,

					       unwinding_header_size, unwinding_size,

					       eh_frame_base_offset);

		if (retval)

			goto error;

	}



	/*

	 * setup section headers string table

	 */
@@ -304,7 +400,7 @@ jit_write_elf(int fd, uint64_t load_addr, const char *sym, 
	shdr->sh_type = SHT_SYMTAB;

	shdr->sh_flags = 0;

	shdr->sh_entsize = sizeof(Elf_Sym);

	shdr->sh_link = 4; /* index of .strtab section */

	shdr->sh_link = unwinding ? 6 : 4; /* index of .strtab section */



	/*

	 * setup symbols string table

tools/perf/util/genelf.h

+2 −1
Original line number Diff line number Diff line
@@ -3,7 +3,8 @@ 


/* genelf.c */

int jit_write_elf(int fd, uint64_t code_addr, const char *sym,

		  const void *code, int csize, void *debug, int nr_debug_entries);

		  const void *code, int csize, void *debug, int nr_debug_entries,

		  void *unwinding, uint64_t unwinding_header_size, uint64_t unwinding_size);

#ifdef HAVE_DWARF_SUPPORT

/* genelf_debug.c */

int jit_add_debug_info(Elf *e, uint64_t code_addr, void *debug, int nr_debug_entries);

tools/perf/util/jitdump.c

+8 −3
Original line number Diff line number Diff line
@@ -72,7 +72,10 @@ jit_emit_elf(char *filename, 
	     const void *code,

	     int csize,

	     void *debug,

	     int nr_debug_entries)

	     int nr_debug_entries,

	     void *unwinding,

	     uint32_t unwinding_header_size,

	     uint32_t unwinding_size)

{

	int ret, fd;
@@ -85,7 +88,8 @@ jit_emit_elf(char *filename, 
		return -1;

	}



        ret = jit_write_elf(fd, code_addr, sym, (const void *)code, csize, debug, nr_debug_entries);

	ret = jit_write_elf(fd, code_addr, sym, (const void *)code, csize, debug, nr_debug_entries,

			    unwinding, unwinding_header_size, unwinding_size);



        close(fd);
@@ -412,7 +416,8 @@ static int jit_repipe_code_load(struct jit_buf_desc *jd, union jr_entry *jr) 


	size = PERF_ALIGN(size, sizeof(u64));

	uaddr = (uintptr_t)code;

	ret = jit_emit_elf(filename, sym, addr, (const void *)uaddr, csize, jd->debug_data, jd->nr_debug_entries);

	ret = jit_emit_elf(filename, sym, addr, (const void *)uaddr, csize, jd->debug_data, jd->nr_debug_entries,

			   jd->unwinding_data, jd->eh_frame_hdr_size, jd->unwinding_size);



	if (jd->debug_data && jd->nr_debug_entries) {

		free(jd->debug_data);

CRA Git | Maintained and supported by SUSTech CRA and CCSE