Commit 0864c408 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

debugfs: remove return value of debugfs_create_x64() 

No one checks the return value of debugfs_create_x64(), as it's not
needed, so make the return value void, so that no one tries to do so in
the future.

Link: https://lore.kernel.org/r/20191011132931.1186197-8-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f5cb0a7e

Documentation/filesystems/debugfs.txt

+2 −2
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ the following functions can be used instead: 
			    struct dentry *parent, u16 *value);

    void debugfs_create_x32(const char *name, umode_t mode,

			    struct dentry *parent, u32 *value);

    struct dentry *debugfs_create_x64(const char *name, umode_t mode,

    void debugfs_create_x64(const char *name, umode_t mode,

			    struct dentry *parent, u64 *value);



These functions are useful as long as the developer knows the size of the

fs/debugfs/file.c

+3 −3
Original line number Diff line number Diff line
@@ -687,10 +687,10 @@ EXPORT_SYMBOL_GPL(debugfs_create_x32); 
 * @value: a pointer to the variable that the file should read to and write

 *         from.

 */

struct dentry *debugfs_create_x64(const char *name, umode_t mode,

				 struct dentry *parent, u64 *value)

void debugfs_create_x64(const char *name, umode_t mode, struct dentry *parent,

			u64 *value)

{

	return debugfs_create_mode_unsafe(name, mode, parent, value, &fops_x64,

	debugfs_create_mode_unsafe(name, mode, parent, value, &fops_x64,

				   &fops_x64_ro, &fops_x64_wo);

}

EXPORT_SYMBOL_GPL(debugfs_create_x64);

include/linux/debugfs.h

+4 −8
Original line number Diff line number Diff line
@@ -113,8 +113,8 @@ void debugfs_create_x16(const char *name, umode_t mode, struct dentry *parent, 
			u16 *value);

void debugfs_create_x32(const char *name, umode_t mode, struct dentry *parent,

			u32 *value);

struct dentry *debugfs_create_x64(const char *name, umode_t mode,

				  struct dentry *parent, u64 *value);

void debugfs_create_x64(const char *name, umode_t mode, struct dentry *parent,

			u64 *value);

void debugfs_create_size_t(const char *name, umode_t mode,

			   struct dentry *parent, size_t *value);

struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,
@@ -281,12 +281,8 @@ static inline void debugfs_create_x16(const char *name, umode_t mode, 
static inline void debugfs_create_x32(const char *name, umode_t mode,

				      struct dentry *parent, u32 *value) { }



static inline struct dentry *debugfs_create_x64(const char *name, umode_t mode,

						struct dentry *parent,

						u64 *value)

{

	return ERR_PTR(-ENODEV);

}

static inline void debugfs_create_x64(const char *name, umode_t mode,

				      struct dentry *parent, u64 *value) { }



static inline void debugfs_create_size_t(const char *name, umode_t mode,

					 struct dentry *parent, size_t *value)

CRA Git | Maintained and supported by SUSTech CRA and CCSE