mtd: Blackfin NFC: fix raw page write/read handling (085d45fb) · Commits · 戴 / test

Our write_buf/read_buf funcs always do ECC in HW ECC mode. That is not needed for raw funcs. In fact, write_buf/read_buf should be a pure func for data input/output while chip->ecc.hwctl controls ECC. Unfortunately, we can't separate ECC from normal data input/output in our NFC, so our DMA write_buf/read_buf entries are coupled with ECC operations closely. Thus we need to provide dedicated read_page_raw/write_page_raw funcs where we do non-DMA transactions so as to avoid automatic ECC. Signed-off-by:

Barry Song <barry.song@analog.com> Signed-off-by:

Mike Frysinger <vapier@gentoo.org> Signed-off-by:

David Woodhouse <David.Woodhouse@intel.com>

drivers/mtd/nand/bf5xx_nand.c

+18 −0

Original line number	Diff line number	Diff line
		@@ -571,6 +571,22 @@ static void bf5xx_nand_dma_write_buf(struct mtd_info *mtd,
		bf5xx_nand_write_buf(mtd, buf, len);
		}

		static int bf5xx_nand_read_page_raw(struct mtd_info mtd, struct nand_chip chip,
		uint8_t *buf, int page)
		{
		bf5xx_nand_read_buf(mtd, buf, mtd->writesize);
		bf5xx_nand_read_buf(mtd, chip->oob_poi, mtd->oobsize);

		return 0;
		}

		static void bf5xx_nand_write_page_raw(struct mtd_info mtd, struct nand_chip chip,
		const uint8_t *buf)
		{
		bf5xx_nand_write_buf(mtd, buf, mtd->writesize);
		bf5xx_nand_write_buf(mtd, chip->oob_poi, mtd->oobsize);
		}

		/*
		* System initialization functions
		*/
		@@ -795,6 +811,8 @@ static int __devinit bf5xx_nand_probe(struct platform_device *pdev)
		chip->ecc.correct = bf5xx_nand_correct_data;
		chip->ecc.mode = NAND_ECC_HW;
		chip->ecc.hwctl = bf5xx_nand_enable_hwecc;
		chip->ecc.read_page_raw = bf5xx_nand_read_page_raw;
		chip->ecc.write_page_raw = bf5xx_nand_write_page_raw;
		} else {
		chip->ecc.mode = NAND_ECC_SOFT;
		}

Admin message