Commit 084fafe9 authored Jan 31, 2019 by Petr Machata Committed by David S. Miller Feb 01, 2019

selftests: forwarding: mirror_gre_flower: Fix test result handling

The global variable RET needs to be initialized before each call to
log_test. This test case sets it once before running the tests, but then
calls log_tests for every individual test. Thus a failure in one of the
tests causes spurious failures in follow-up tests as well.

Fix by moving the initialization of RET from test_all() to
full_test_span_gre_dir_acl(), a function that implements the test.

Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2243cad9

tools/testing/selftests/net/forwarding/mirror_gre_flower.sh

+2 −2

Original line number	Diff line number	Diff line
		@@ -81,6 +81,8 @@ full_test_span_gre_dir_acl()
		local match_dip=$1; shift
		local what=$1; shift

		RET=0

		mirror_install $swp1 $direction $tundev \
		"protocol ip flower $tcflags dst_ip $match_dip"
		fail_test_span_gre_dir $tundev $direction
		@@ -108,8 +110,6 @@ test_ip6gretap()

		test_all()
		{
		RET=0

		slow_path_trap_install $swp1 ingress
		slow_path_trap_install $swp1 egress

Admin message