Commit 083db676 authored Jul 17, 2019 by Josh Poimboeuf Committed by Thomas Gleixner Jul 18, 2019

x86/paravirt: Fix callee-saved function ELF sizes

The __raw_callee_save_*() functions have an ELF symbol size of zero,
which confuses objtool and other tools.

Fixes a bunch of warnings like the following:

arch/x86/xen/mmu_pv.o: warning: objtool: __raw_callee_save_xen_pte_val() is missing an ELF size annotation
arch/x86/xen/mmu_pv.o: warning: objtool: __raw_callee_save_xen_pgd_val() is missing an ELF size annotation
arch/x86/xen/mmu_pv.o: warning: objtool: __raw_callee_save_xen_make_pte() is missing an ELF size annotation
arch/x86/xen/mmu_pv.o: warning: objtool: __raw_callee_save_xen_make_pgd() is missing an ELF size annotation

Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Juergen Gross <jgross@suse.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/afa6d49bb07497ca62e4fc3b27a2d0cece545b4e.1563413318.git.jpoimboe@redhat.com

parent 54f698f3

arch/x86/include/asm/paravirt.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -746,6 +746,7 @@ bool __raw_callee_save___native_vcpu_is_preempted(long cpu);
		PV_RESTORE_ALL_CALLER_REGS \
		FRAME_END \
		"ret;" \
		".size " PV_THUNK_NAME(func) ", .-" PV_THUNK_NAME(func) ";" \
		".popsection")

		/* Get a reference to a callee-save function */

+1 −0

Original line number	Diff line number	Diff line
		@@ -838,6 +838,7 @@ asm(
		"cmpb $0, " __stringify(KVM_STEAL_TIME_preempted) "+steal_time(%rax);"
		"setne %al;"
		"ret;"
		".size __raw_callee_save___kvm_vcpu_is_preempted, .-__raw_callee_save___kvm_vcpu_is_preempted;"
		".popsection");

		#endif