Commit 0825a6f9 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

mm: use octal not symbolic permissions 

mm/*.c files use symbolic and octal styles for permissions.

Using octal and not symbolic permissions is preferred by many as more
readable.

https://lkml.org/lkml/2016/8/2/1945

Prefer the direct use of octal for permissions.

Done using
$ scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace mm/*.c
and some typing.

Before:	 $ git grep -P -w "0[0-7]{3,3}" mm | wc -l
44
After:	 $ git grep -P -w "0[0-7]{3,3}" mm | wc -l
86

Miscellanea:

o Whitespace neatening around these conversions.

Link: http://lkml.kernel.org/r/2e032ef111eebcd4c5952bae86763b541d373469.1522102887.git.joe@perches.com


Signed-off-by: default avatarJoe Perches <joe@perches.com>
Acked-by: default avatarDavid Rientjes <rientjes@google.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 14f28f57

mm/cleancache.c

+4 −6
Original line number Diff line number Diff line
@@ -307,12 +307,10 @@ static int __init init_cleancache(void) 
	struct dentry *root = debugfs_create_dir("cleancache", NULL);

	if (root == NULL)

		return -ENXIO;

	debugfs_create_u64("succ_gets", S_IRUGO, root, &cleancache_succ_gets);

	debugfs_create_u64("failed_gets", S_IRUGO,

				root, &cleancache_failed_gets);

	debugfs_create_u64("puts", S_IRUGO, root, &cleancache_puts);

	debugfs_create_u64("invalidates", S_IRUGO,

				root, &cleancache_invalidates);

	debugfs_create_u64("succ_gets", 0444, root, &cleancache_succ_gets);

	debugfs_create_u64("failed_gets", 0444, root, &cleancache_failed_gets);

	debugfs_create_u64("puts", 0444, root, &cleancache_puts);

	debugfs_create_u64("invalidates", 0444, root, &cleancache_invalidates);

#endif

	return 0;

}

mm/cma_debug.c

+10 −15
Original line number Diff line number Diff line
@@ -172,23 +172,18 @@ static void cma_debugfs_add_one(struct cma *cma, int idx) 


	tmp = debugfs_create_dir(name, cma_debugfs_root);



	debugfs_create_file("alloc", S_IWUSR, tmp, cma,

				&cma_alloc_fops);



	debugfs_create_file("free", S_IWUSR, tmp, cma,

				&cma_free_fops);



	debugfs_create_file("base_pfn", S_IRUGO, tmp,

	debugfs_create_file("alloc", 0200, tmp, cma, &cma_alloc_fops);

	debugfs_create_file("free", 0200, tmp, cma, &cma_free_fops);

	debugfs_create_file("base_pfn", 0444, tmp,

			    &cma->base_pfn, &cma_debugfs_fops);

	debugfs_create_file("count", S_IRUGO, tmp,

				&cma->count, &cma_debugfs_fops);

	debugfs_create_file("order_per_bit", S_IRUGO, tmp,

	debugfs_create_file("count", 0444, tmp, &cma->count, &cma_debugfs_fops);

	debugfs_create_file("order_per_bit", 0444, tmp,

			    &cma->order_per_bit, &cma_debugfs_fops);

	debugfs_create_file("used", S_IRUGO, tmp, cma, &cma_used_fops);

	debugfs_create_file("maxchunk", S_IRUGO, tmp, cma, &cma_maxchunk_fops);

	debugfs_create_file("used", 0444, tmp, cma, &cma_used_fops);

	debugfs_create_file("maxchunk", 0444, tmp, cma, &cma_maxchunk_fops);



	u32s = DIV_ROUND_UP(cma_bitmap_maxno(cma), BITS_PER_BYTE * sizeof(u32));

	debugfs_create_u32_array("bitmap", S_IRUGO, tmp, (u32*)cma->bitmap, u32s);

	debugfs_create_u32_array("bitmap", 0444, tmp, (u32 *)cma->bitmap, u32s);

}



static int __init cma_debugfs_init(void)

mm/compaction.c

+1 −1
Original line number Diff line number Diff line
@@ -1899,7 +1899,7 @@ static ssize_t sysfs_compact_node(struct device *dev, 


	return count;

}

static DEVICE_ATTR(compact, S_IWUSR, NULL, sysfs_compact_node);

static DEVICE_ATTR(compact, 0200, NULL, sysfs_compact_node);



int compaction_register_node(struct node *node)

{

mm/dmapool.c

+1 −1
Original line number Diff line number Diff line
@@ -105,7 +105,7 @@ show_pools(struct device *dev, struct device_attribute *attr, char *buf) 
	return PAGE_SIZE - size;

}



static DEVICE_ATTR(pools, S_IRUGO, show_pools, NULL);

static DEVICE_ATTR(pools, 0444, show_pools, NULL);



/**

 * dma_pool_create - Creates a pool of consistent memory blocks, for dma.

mm/failslab.c

+1 −1
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ __setup("failslab=", setup_failslab); 
static int __init failslab_debugfs_init(void)

{

	struct dentry *dir;

	umode_t mode = S_IFREG | S_IRUSR | S_IWUSR;

	umode_t mode = S_IFREG | 0600;



	dir = fault_create_debugfs_attr("failslab", NULL, &failslab.attr);

	if (IS_ERR(dir))

CRA Git | Maintained and supported by SUSTech CRA and CCSE