Commit 07fb75a5 authored May 14, 2006 by Jesper Juhl Committed by James Bottomley May 20, 2006

[SCSI] fix (unlikely) memory leak in DAC960 driver



The Coverity checker found a memory leak (bug nr. 1245) in
 drivers/block/DAC960.c::DAC960_V2_ProcessCompletedCommand()

The leak is pretty unlikely since it requires that the first of two
successive kmalloc() calls fail while the second one succeeds. But it can
still happen even if it's unlikely.

If the first call that allocates 'PhysicalDeviceInfo' fails but the one
that allocates 'InquiryUnitSerialNumber' succeeds, then we will leak the
memory allocated to 'InquiryUnitSerialNumber' when the variable goes out
of scope.

A simple fix for this is to change the existing code that frees
'PhysicalDeviceInfo' if that one was allocated but
'InquiryUnitSerialNumber' was not, into a check for either pointer
being NULL and if so just free both. This is safe since kfree() can
deal with being passed a NULL pointer and it avoids the leak.

While I was there I also removed the casts of the kmalloc() return
value since it's pointless.
I also updated the driver version since this patch changes the workings of
the code (however slightly).

This issue could probably be fixed a lot more elegantly, but the code
is a big mess IMHO and I just took the least intrusive route to a fix
that I could find instead of starting on a cleanup as well (that can
come later).

Please consider for inclusion.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

parent 5b9851b5

drivers/block/DAC960.c

+7 −6

Original line number	Diff line number	Diff line
		@@ -17,8 +17,8 @@
		*/


		#define DAC960_DriverVersion "2.5.47"
		#define DAC960_DriverDate "14 November 2002"
		#define DAC960_DriverVersion "2.5.48"
		#define DAC960_DriverDate "14 May 2006"


		#include <linux/module.h>
		@@ -4780,15 +4780,16 @@ static void DAC960_V2_ProcessCompletedCommand(DAC960_Command_T *Command)
		(NewPhysicalDeviceInfo->LogicalUnit !=
		PhysicalDeviceInfo->LogicalUnit))
		{
		PhysicalDeviceInfo = (DAC960_V2_PhysicalDeviceInfo_T *)
		PhysicalDeviceInfo =
		kmalloc(sizeof(DAC960_V2_PhysicalDeviceInfo_T), GFP_ATOMIC);
		InquiryUnitSerialNumber =
		(DAC960_SCSI_Inquiry_UnitSerialNumber_T *)
		kmalloc(sizeof(DAC960_SCSI_Inquiry_UnitSerialNumber_T),
		GFP_ATOMIC);
		if (InquiryUnitSerialNumber == NULL &&
		PhysicalDeviceInfo != NULL)
		if (InquiryUnitSerialNumber == NULL \|\|
		PhysicalDeviceInfo == NULL)
		{
		kfree(InquiryUnitSerialNumber);
		InquiryUnitSerialNumber = NULL;
		kfree(PhysicalDeviceInfo);
		PhysicalDeviceInfo = NULL;
		}

Admin message