Commit 07fb6f26 authored Mar 04, 2008 by Julia Lawall Committed by Linus Torvalds Mar 04, 2008

drivers/char/isicom.c: correct use of ! and &

In commit e6bafba5 ("wmi: (!x & y)
strikes again"), a bug was fixed that involved converting !x & y to !(x
& y).  The code below shows the same pattern, and thus should perhaps be
fixed in the same way.

This is not tested and clearly changes the semantics, so it is only
something to consider.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@@ expression E1,E2; @@
(
  !E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent fb59e9f1

drivers/char/isicom.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1527,7 +1527,7 @@ static int __devinit reset_card(struct pci_dev *pdev,
		msleep(10);

		portcount = inw(base + 0x2);
		if (!inw(base + 0xe) & 0x1 \|\| (portcount != 0 && portcount != 4 &&
		if (!(inw(base + 0xe) & 0x1) \|\| (portcount != 0 && portcount != 4 &&
		portcount != 8 && portcount != 16)) {
		dev_err(&pdev->dev, "ISILoad:PCI Card%d reset failure.\n",
		card + 1);

Admin message