Commit 07f8569f authored Oct 04, 2020 by Rikard Falkeborn Committed by Greg Kroah-Hartman Oct 05, 2020

w1: Constify struct w1_family_ops

The fops field in the w1_family struct is never modified. Make it const
to indicate that. Constifying the pointer makes it possible for drivers
to declare static w1_family_ops structs const, which in turn will allow
the compiler to put it in read-only memory.

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Link: https://lore.kernel.org/r/20201004193202.4044-2-rikard.falkeborn@gmail.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9f126c56

drivers/w1/w1.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -613,7 +613,7 @@ end:

		static int w1_family_notify(unsigned long action, struct w1_slave *sl)
		{
		struct w1_family_ops *fops;
		const struct w1_family_ops *fops;
		int err;

		fops = sl->family->fops;

+1 −1

Original line number	Diff line number	Diff line
		@@ -269,7 +269,7 @@ struct w1_family {
		struct list_head family_entry;
		u8 fid;

		struct w1_family_ops *fops;
		const struct w1_family_ops *fops;

		const struct of_device_id *of_match_table;