Commit 07f5ab60 authored Feb 23, 2017 by Vaibhav Jain Committed by Michael Ellerman Mar 20, 2017

cxl: Route eeh events to all slices for pci_channel_io_perm_failure state

Fix a boundary condition where in some cases an eeh event with state ==
pci_channel_io_perm_failure wont be passed on to a driver attached to
the virtual PCI device associated with a slice. This will happen in case
the slice just before (n-1) doesn't have any vPHB bus associated with
it, that results in an early return from cxl_pci_error_detected()
callback.

With state == pci_channel_io_perm_failure, the adapter will be removed
irrespective of the return value of cxl_vphb_error_detected(). So we now
always return PCI_ERS_RESULT_DISCONNECTED for this case i.e even if
the AFU isn't using a vPHB (currently returns PCI_ERS_RESULT_NONE).

Fixes: e4f5fc00("cxl: Do not create vPHB if there are no AFU configuration records")
Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 97da3854

drivers/misc/cxl/pci.c

+6 −7

Original line number	Diff line number	Diff line
		@@ -1792,14 +1792,13 @@ static pci_ers_result_t cxl_pci_error_detected(struct pci_dev *pdev,

		/* If we're permanently dead, give up. */
		if (state == pci_channel_io_perm_failure) {
		/* Tell the AFU drivers; but we don't care what they
		* say, we're going away.
		*/
		for (i = 0; i < adapter->slices; i++) {
		afu = adapter->afu[i];
		/* Only participate in EEH if we are on a virtual PHB */
		if (afu->phb == NULL)
		return PCI_ERS_RESULT_NONE;
		/*
		* Tell the AFU drivers; but we don't care what they
		* say, we're going away.
		*/
		if (afu->phb != NULL)
		cxl_vphb_error_detected(afu, state);
		}
		return PCI_ERS_RESULT_DISCONNECT;

Admin message