Commit 07f438df authored by Hanjun Guo's avatar Hanjun Guo Committed by Will Deacon
Browse files

ACPI / table: Use pr_debug() instead of pr_info() for MADT table scanning 



For a normal 8 cpu sockets system, it will up to 240 cpu threads (Xeon E7
v2 family for now), and we need 240 entries for local apic or local x2apic
in MADT table, so it will be much verbose information printed with a slow
uart console when system booted, this will be even worse with large system
with 16/32 cpu sockets.

This patch just use pr_debug() instead of pr_info() for ioapic/iosapic,
local apic/x2apic/sapic structures when scanning the MADT table to remove
those verbose information, but leave other structures unchanged.

CC: Rafael J Wysocki <rjw@rjwysocki.net>
Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarOlof Johansson <olof@lixom.net>
Acked-by: default avatarGrant Likely <grant.likely@linaro.org>
Tested-by: default avatarTimur Tabi <timur@codeaurora.org>
Signed-off-by: default avatarHanjun Guo <hanjun.guo@linaro.org>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
parent 06e5801b

drivers/acpi/tables.c

+16 −14
Original line number Diff line number Diff line
@@ -23,6 +23,8 @@ 
 *

 */



/* Uncomment next line to get verbose printout */

/* #define DEBUG */

#define pr_fmt(fmt) "ACPI: " fmt



#include <linux/init.h>
@@ -61,7 +63,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) 
		{

			struct acpi_madt_local_apic *p =

			    (struct acpi_madt_local_apic *)header;

			pr_info("LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n",

			pr_debug("LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n",

				 p->processor_id, p->id,

				 (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");

		}
@@ -71,7 +73,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) 
		{

			struct acpi_madt_local_x2apic *p =

			    (struct acpi_madt_local_x2apic *)header;

			pr_info("X2APIC (apic_id[0x%02x] uid[0x%02x] %s)\n",

			pr_debug("X2APIC (apic_id[0x%02x] uid[0x%02x] %s)\n",

				 p->local_apic_id, p->uid,

				 (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");

		}
@@ -81,7 +83,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) 
		{

			struct acpi_madt_io_apic *p =

			    (struct acpi_madt_io_apic *)header;

			pr_info("IOAPIC (id[0x%02x] address[0x%08x] gsi_base[%d])\n",

			pr_debug("IOAPIC (id[0x%02x] address[0x%08x] gsi_base[%d])\n",

				 p->id, p->address, p->global_irq_base);

		}

		break;
@@ -155,7 +157,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) 
		{

			struct acpi_madt_io_sapic *p =

			    (struct acpi_madt_io_sapic *)header;

			pr_info("IOSAPIC (id[0x%x] address[%p] gsi_base[%d])\n",

			pr_debug("IOSAPIC (id[0x%x] address[%p] gsi_base[%d])\n",

				 p->id, (void *)(unsigned long)p->address,

				 p->global_irq_base);

		}
@@ -165,7 +167,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) 
		{

			struct acpi_madt_local_sapic *p =

			    (struct acpi_madt_local_sapic *)header;

			pr_info("LSAPIC (acpi_id[0x%02x] lsapic_id[0x%02x] lsapic_eid[0x%02x] %s)\n",

			pr_debug("LSAPIC (acpi_id[0x%02x] lsapic_id[0x%02x] lsapic_eid[0x%02x] %s)\n",

				 p->processor_id, p->id, p->eid,

				 (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");

		}

CRA Git | Maintained and supported by SUSTech CRA and CCSE