Commit 07edd741 authored Jan 08, 2014 by Hannes Frederic Sowa Committed by David S. Miller Jan 09, 2014

ipv6: add link-local, sit and loopback address with INFINITY_LIFE_TIME

In the past the IFA_PERMANENT flag indicated, that the valid and preferred
lifetime where ignored. Since change fad8da3e ("ipv6 addrconf: fix
preferred lifetime state-changing behavior while valid_lft is infinity")
we honour at least the preferred lifetime on those addresses. As such
the valid lifetime gets recalculated and updated to 0.

If loopback address is added manually this problem does not occur.
Also if NetworkManager manages IPv6, those addresses will get added via
inet6_rtm_newaddr and thus will have a correct lifetime, too.

Reported-by: François-Xavier Le Bail <fx.lebail@yahoo.com>
Reported-by: Damien Wyart <damien.wyart@gmail.com>
Fixes: fad8da3e ("ipv6 addrconf: fix preferred lifetime state-changing behavior while valid_lft is infinity")
Cc: Yasushi Asano <yasushi.asano@jp.fujitsu.com>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9a2620c8

net/ipv6/addrconf.c

+4 −2

Original line number	Original line	Diff line number	Diff line
	@@ -2509,7 +2509,8 @@ static void add_addr(struct inet6_dev idev, const struct in6_addr addr,
	struct inet6_ifaddr *ifp;		struct inet6_ifaddr *ifp;

	ifp = ipv6_add_addr(idev, addr, NULL, plen,		ifp = ipv6_add_addr(idev, addr, NULL, plen,
	scope, IFA_F_PERMANENT, 0, 0);		scope, IFA_F_PERMANENT,
			INFINITY_LIFE_TIME, INFINITY_LIFE_TIME);
	if (!IS_ERR(ifp)) {		if (!IS_ERR(ifp)) {
	spin_lock_bh(&ifp->lock);		spin_lock_bh(&ifp->lock);
	ifp->flags &= ~IFA_F_TENTATIVE;		ifp->flags &= ~IFA_F_TENTATIVE;
	@@ -2637,7 +2638,8 @@ static void addrconf_add_linklocal(struct inet6_dev *idev, const struct in6_addr
	#endif		#endif


	ifp = ipv6_add_addr(idev, addr, NULL, 64, IFA_LINK, addr_flags, 0, 0);		ifp = ipv6_add_addr(idev, addr, NULL, 64, IFA_LINK, addr_flags,
			INFINITY_LIFE_TIME, INFINITY_LIFE_TIME);
	if (!IS_ERR(ifp)) {		if (!IS_ERR(ifp)) {
	addrconf_prefix_route(&ifp->addr, ifp->prefix_len, idev->dev, 0, 0);		addrconf_prefix_route(&ifp->addr, ifp->prefix_len, idev->dev, 0, 0);
	addrconf_dad_start(ifp);		addrconf_dad_start(ifp);

Admin message