Commit 07d50cae authored Aug 04, 2016 by Ido Schimmel Committed by David S. Miller Aug 08, 2016

mlxsw: spectrum: Do not override PAUSE settings



The PFCC register is used to configure both PAUSE and PFC frames.
Therefore, when PFC frames are disabled we must make sure we don't
mistakenly also disable PAUSE frames (which might be enabled).

Fix this by packing the PFCC register with the current PAUSE settings.

Note that this register is also accessed via ethtool ops, but there we
are guaranteed to have PFC disabled.

Fixes: d81a6bdb ("mlxsw: spectrum: Add IEEE 802.1Qbb PFC support")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b489a200

drivers/net/ethernet/mellanox/mlxsw/spectrum_dcb.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -341,6 +341,8 @@ static int mlxsw_sp_port_pfc_set(struct mlxsw_sp_port *mlxsw_sp_port,
		char pfcc_pl[MLXSW_REG_PFCC_LEN];

		mlxsw_reg_pfcc_pack(pfcc_pl, mlxsw_sp_port->local_port);
		mlxsw_reg_pfcc_pprx_set(pfcc_pl, mlxsw_sp_port->link.rx_pause);
		mlxsw_reg_pfcc_pptx_set(pfcc_pl, mlxsw_sp_port->link.tx_pause);
		mlxsw_reg_pfcc_prio_pack(pfcc_pl, pfc->pfc_en);

		return mlxsw_reg_write(mlxsw_sp_port->mlxsw_sp->core, MLXSW_REG(pfcc),

Admin message