Commit 07d5035a authored Apr 17, 2014 by Dave Chinner Committed by Dave Chinner Apr 17, 2014

xfs: wrong error sign conversion during failed DIO writes



We negate the error value being returned from a generic function
incorrectly. The code path that it is running in returned negative
errors, so there is no need to negate it to get the correct error
signs here.

This was uncovered by generic/019.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>

parent 9c23eccc

fs/xfs/xfs_file.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -679,7 +679,7 @@ xfs_file_dio_aio_write(
		goto out;

		if (mapping->nrpages) {
		ret = -filemap_write_and_wait_range(VFS_I(ip)->i_mapping,
		ret = filemap_write_and_wait_range(VFS_I(ip)->i_mapping,
		pos, -1);
		if (ret)
		goto out;

Admin message