Commit 07c5c3ad authored by Tero Kristo's avatar Tero Kristo Committed by Mark Brown
Browse files

regulator: core: remove lockdep assert from suspend_prepare



suspend_prepare can be called during regulator init time also, where
the mutex is not locked yet. This causes a false lockdep warning.
To avoid the problem, remove the lockdep assertion from the function
causing the issue. An alternative would be to lock the mutex during
init, but this would cause other problems (some APIs used during init
will attempt to lock the mutex also, causing deadlock.)

Signed-off-by: default avatarTero Kristo <t-kristo@ti.com>
Reported-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 9d2597e8
Loading
Loading
Loading
Loading
+0 −2
Original line number Diff line number Diff line
@@ -808,8 +808,6 @@ static int suspend_set_state(struct regulator_dev *rdev,
/* locks held by caller */
static int suspend_prepare(struct regulator_dev *rdev, suspend_state_t state)
{
	lockdep_assert_held_once(&rdev->mutex);

	if (!rdev->constraints)
		return -EINVAL;