Commit 07bedca2 authored by Alex Chiang's avatar Alex Chiang Committed by Len Brown
Browse files

ACPI: DMI init_set_sci_en_on_resume for multiple Lenovo ThinkPads 

Multiple Lenovo ThinkPad models with Intel Core i5/i7 CPUs can
successfully suspend/resume once, and then hang on the second s/r
cycle.

We got confirmation that this was due to a BIOS defect. The BIOS
did not properly set SCI_EN coming out of S3. The BIOS guys
hinted that The Other Leading OS ignores the fact that hardware
owns the bit and sets it manually.

In any case, an existing DMI table exists for machines where this
defect is a known problem. Lenovo promise to fix their BIOS, but
for folks who either won't or can't upgrade their BIOS, allow
Linux to workaround the issue.

https://bugzilla.kernel.org/show_bug.cgi?id=15407
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/532374



Confirmed by numerous testers in the launchpad bug that using
acpi_sleep=sci_force_enable fixes the issue. We add the machines
to acpisleep_dmi_table[] to automatically enable this workaround.

Cc: stable@kernel.org
Cc: Colin King <colin.king@canonical.com>
Signed-off-by: default avatarAlex Chiang <achiang@canonical.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 8777c793

drivers/acpi/sleep.c

+120 −0
Original line number Diff line number Diff line
@@ -450,6 +450,126 @@ static struct dmi_system_id __initdata acpisleep_dmi_table[] = { 
		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad T410",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T410"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad T510",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T510"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad W510",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad W510"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad X201",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X201"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad X201",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X201s"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad T410",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T410"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad T510",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T510"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad W510",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad W510"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad X201",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X201"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad X201",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X201s"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad T410",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T410"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad T510",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T510"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad W510",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad W510"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad X201",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X201"),

		},

	},

	{

	.callback = init_set_sci_en_on_resume,

	.ident = "Lenovo ThinkPad X201",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X201s"),

		},

	},

	{

	.callback = init_old_suspend_ordering,

	.ident = "Panasonic CF51-2L",

	.matches = {

CRA Git | Maintained and supported by SUSTech CRA and CCSE