Commit 0773cea3 authored Apr 18, 2017 by Matthias Kaehlcke Committed by Thomas Gleixner Apr 20, 2017

clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK

Besides reusing existing code this removes the special case handling
for 64-bit masks, which causes clang to raise a shift count overflow
warning due to https://bugs.llvm.org//show_bug.cgi?id=10030

.

Suggested-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Cc: Grant Grundler <grundler@chromium.org>
Cc: Greg Hackmann <ghackmann@google.com>
Cc: Michael Davidson <md@google.com>
Cc: John Stultz <john.stultz@linaro.org>
Link: http://lkml.kernel.org/r/20170418233037.70990-1-mka@chromium.org


Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 26e42a02

include/linux/clocksource.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -120,7 +120,7 @@ struct clocksource {
		#define CLOCK_SOURCE_RESELECT 0x100

		/* simplify initialization of mask field */
		#define CLOCKSOURCE_MASK(bits) (u64)((bits) < 64 ? ((1ULL<<(bits))-1) : -1)
		#define CLOCKSOURCE_MASK(bits) GENMASK_ULL((bits) - 1, 0)

		static inline u32 clocksource_freq2mult(u32 freq, u32 shift_constant, u64 from)
		{

Admin message