Commit 076c6e45 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf session: Free the ref_reloc_sym memory at the right place 



Which is at perf_session__destroy_kernel_maps, counterpart to the
perf_session__create_kernel_maps where the kmap structure is located, just
after the vmlinux_maps.

Make it also check if the kernel maps were actually created, which may not
be the case if, for instance, perf_session__new can't complete due to
permission problems in, for instance, a 'perf report' case, when a
segfault will take place, that is how this was noticed.

The problem was introduced in d65a458b, thus post .35.

This also adds code to release guest machines as them are also created
in perf_session__create_kernel_maps, so should be deleted on this newly
introduced counterpart, perf_session__destroy_kernel_maps.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <new-submission>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 3772b734

tools/perf/util/map.c

+11 −7
Original line number Diff line number Diff line
@@ -506,6 +506,11 @@ void maps__insert(struct rb_root *maps, struct map *map) 
	rb_insert_color(&map->rb_node, maps);

}



void maps__remove(struct rb_root *self, struct map *map)

{

	rb_erase(&map->rb_node, self);

}



struct map *maps__find(struct rb_root *maps, u64 ip)

{

	struct rb_node **p = &maps->rb_node;
@@ -551,13 +556,6 @@ static void dsos__delete(struct list_head *self) 


void machine__exit(struct machine *self)

{

	struct kmap *kmap = map__kmap(self->vmlinux_maps[MAP__FUNCTION]);



	if (kmap->ref_reloc_sym) {

		free((char *)kmap->ref_reloc_sym->name);

		free(kmap->ref_reloc_sym);

	}



	map_groups__exit(&self->kmaps);

	dsos__delete(&self->user_dsos);

	dsos__delete(&self->kernel_dsos);
@@ -565,6 +563,12 @@ void machine__exit(struct machine *self) 
	self->root_dir = NULL;

}



void machine__delete(struct machine *self)

{

	machine__exit(self);

	free(self);

}



struct machine *machines__add(struct rb_root *self, pid_t pid,

			      const char *root_dir)

{

tools/perf/util/map.h

+7 −0
Original line number Diff line number Diff line
@@ -125,6 +125,7 @@ void map__reloc_vmlinux(struct map *self); 
size_t __map_groups__fprintf_maps(struct map_groups *self,

				  enum map_type type, int verbose, FILE *fp);

void maps__insert(struct rb_root *maps, struct map *map);

void maps__remove(struct rb_root *self, struct map *map);

struct map *maps__find(struct rb_root *maps, u64 addr);

void map_groups__init(struct map_groups *self);

void map_groups__exit(struct map_groups *self);
@@ -144,6 +145,7 @@ struct machine *machines__findnew(struct rb_root *self, pid_t pid); 
char *machine__mmap_name(struct machine *self, char *bf, size_t size);

int machine__init(struct machine *self, const char *root_dir, pid_t pid);

void machine__exit(struct machine *self);

void machine__delete(struct machine *self);



/*

 * Default guest kernel is defined by parameter --guestkallsyms
@@ -165,6 +167,11 @@ static inline void map_groups__insert(struct map_groups *self, struct map *map) 
	map->groups = self;

}



static inline void map_groups__remove(struct map_groups *self, struct map *map)

{

	maps__remove(&self->maps[map->type], map);

}



static inline struct map *map_groups__find(struct map_groups *self,

					   enum map_type type, u64 addr)

{

tools/perf/util/session.c

+7 −0
Original line number Diff line number Diff line
@@ -79,6 +79,12 @@ int perf_session__create_kernel_maps(struct perf_session *self) 
	return ret;

}



static void perf_session__destroy_kernel_maps(struct perf_session *self)

{

	machine__destroy_kernel_maps(&self->host_machine);

	machines__destroy_guest_kernel_maps(&self->machines);

}



struct perf_session *perf_session__new(const char *filename, int mode, bool force, bool repipe)

{

	size_t len = filename ? strlen(filename) + 1 : 0;
@@ -150,6 +156,7 @@ static void perf_session__delete_threads(struct perf_session *self) 
void perf_session__delete(struct perf_session *self)

{

	perf_header__exit(&self->header);

	perf_session__destroy_kernel_maps(self);

	perf_session__delete_dead_threads(self);

	perf_session__delete_threads(self);

	machine__exit(&self->host_machine);

tools/perf/util/symbol.c

+43 −0
Original line number Diff line number Diff line
@@ -2107,6 +2107,36 @@ int __machine__create_kernel_maps(struct machine *self, struct dso *kernel) 
	return 0;

}



void machine__destroy_kernel_maps(struct machine *self)

{

	enum map_type type;



	for (type = 0; type < MAP__NR_TYPES; ++type) {

		struct kmap *kmap;



		if (self->vmlinux_maps[type] == NULL)

			continue;



		kmap = map__kmap(self->vmlinux_maps[type]);

		map_groups__remove(&self->kmaps, self->vmlinux_maps[type]);

		if (kmap->ref_reloc_sym) {

			/*

			 * ref_reloc_sym is shared among all maps, so free just

			 * on one of them.

			 */

			if (type == MAP__FUNCTION) {

				free((char *)kmap->ref_reloc_sym->name);

				kmap->ref_reloc_sym->name = NULL;

				free(kmap->ref_reloc_sym);

			}

			kmap->ref_reloc_sym = NULL;

		}



		map__delete(self->vmlinux_maps[type]);

		self->vmlinux_maps[type] = NULL;

	}

}



int machine__create_kernel_maps(struct machine *self)

{

	struct dso *kernel = machine__create_kernel(self);
@@ -2351,6 +2381,19 @@ failure: 
	return ret;

}



void machines__destroy_guest_kernel_maps(struct rb_root *self)

{

	struct rb_node *next = rb_first(self);



	while (next) {

		struct machine *pos = rb_entry(next, struct machine, rb_node);



		next = rb_next(&pos->rb_node);

		rb_erase(&pos->rb_node, self);

		machine__delete(pos);

	}

}



int machine__load_kallsyms(struct machine *self, const char *filename,

			   enum map_type type, symbol_filter_t filter)

{

tools/perf/util/symbol.h

+2 −0
Original line number Diff line number Diff line
@@ -212,11 +212,13 @@ int kallsyms__parse(const char *filename, void *arg, 
		    int (*process_symbol)(void *arg, const char *name,

					  char type, u64 start));



void machine__destroy_kernel_maps(struct machine *self);

int __machine__create_kernel_maps(struct machine *self, struct dso *kernel);

int machine__create_kernel_maps(struct machine *self);



int machines__create_kernel_maps(struct rb_root *self, pid_t pid);

int machines__create_guest_kernel_maps(struct rb_root *self);

void machines__destroy_guest_kernel_maps(struct rb_root *self);



int symbol__init(void);

void symbol__exit(void);

CRA Git | Maintained and supported by SUSTech CRA and CCSE