signal/mips: Remove FPE_FIXME usage from mips (076a9bca) · Commits · 戴 / test

Ralf Baechle recently merged a change to stop explicitly handling this case on mips, as the case is impossible. Unfortunately when the code in force_fcr31_sig to not use siginfo but a simple interger variable gcc starts warning about an unitialized variable. So add a return statement so gcc knows the code never attempts to use the impossible value. Cc: Ralf Baechle <ralf@linux-mips.org> Signed-off-by:

"Eric W. Biederman" <ebiederm@xmission.com>

arch/mips/include/uapi/asm/siginfo.h

+0 −7

Original line number	Diff line number	Diff line
		@@ -123,11 +123,4 @@ typedef struct siginfo {
		#define SI_TIMER -3 /* sent by timer expiration */
		#define SI_MESGQ -4 /* sent by real time mesq state change */

		/*
		* SIGFPE si_codes
		*/
		#ifdef __KERNEL__
		#define FPE_FIXME 0 /* Broken dup of SI_USER */
		#endif /* __KERNEL__ */

		#endif /* _UAPI_ASM_SIGINFO_H */

arch/mips/kernel/traps.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -735,7 +735,7 @@ void force_fcr31_sig(unsigned long fcr31, void __user *fault_addr,
		else if (fcr31 & FPU_CSR_INE_X)
		si.si_code = FPE_FLTRES;
		else
		si.si_code = FPE_FIXME;
		return; /* Broken hardware? */
		force_sig_info(SIGFPE, &si, tsk);
		}

Admin message