PCI: Log IDE resource quirk in dmesg (075eb9e3) · Commits · 戴 / test

Make a note in dmesg when we overwrite legacy IDE BAR info. We previously logged something like this: pci 0000:00:1f.1: reg 0x10: [io 0x0000-0x0007] and then silently overwrote the resource. There's an example in the bugzilla below. This doesn't fix the bugzilla; it just makes what's going on more obvious. No functional change; merely adds some dev_info() calls. Link: https://bugzilla.kernel.org/show_bug.cgi?id=48451 Signed-off-by:

Bjorn Helgaas <bhelgaas@google.com>

drivers/pci/probe.c

+12 −4

Original line number	Diff line number	Diff line
		@@ -1140,11 +1140,15 @@ int pci_setup_device(struct pci_dev *dev)
		res = &dev->resource[0];
		res->flags = LEGACY_IO_RESOURCE;
		pcibios_bus_to_resource(dev->bus, res, &region);
		dev_info(&dev->dev, "legacy IDE quirk: reg 0x10: %pR\n",
		res);
		region.start = 0x3F6;
		region.end = 0x3F6;
		res = &dev->resource[1];
		res->flags = LEGACY_IO_RESOURCE;
		pcibios_bus_to_resource(dev->bus, res, &region);
		dev_info(&dev->dev, "legacy IDE quirk: reg 0x14: %pR\n",
		res);
		}
		if ((progif & 4) == 0) {
		region.start = 0x170;
		@@ -1152,11 +1156,15 @@ int pci_setup_device(struct pci_dev *dev)
		res = &dev->resource[2];
		res->flags = LEGACY_IO_RESOURCE;
		pcibios_bus_to_resource(dev->bus, res, &region);
		dev_info(&dev->dev, "legacy IDE quirk: reg 0x18: %pR\n",
		res);
		region.start = 0x376;
		region.end = 0x376;
		res = &dev->resource[3];
		res->flags = LEGACY_IO_RESOURCE;
		pcibios_bus_to_resource(dev->bus, res, &region);
		dev_info(&dev->dev, "legacy IDE quirk: reg 0x1c: %pR\n",
		res);
		}
		}
		break;

Admin message