btrfs: tree-checker: Check chunk item at tree block read time (075cb3c7) · Commits · 戴 / test

Since we have btrfs_check_chunk_valid() in tree-checker, let's do chunk item verification in tree-checker too. Since the tree-checker is run at endio time, if one chunk leaf fails chunk verification, we can still retry the other copy, making btrfs more robust to fuzzed image as we may still get a good chunk item. Also since we have done chunk verification in tree block read time, skip the btrfs_check_chunk_valid() call in read_one_chunk() if we're reading chunk items from leaf. Reviewed-by:

Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by:

Qu Wenruo <wqu@suse.com> Reviewed-by:

David Sterba <dsterba@suse.com> Signed-off-by:

David Sterba <dsterba@suse.com>

fs/btrfs/tree-checker.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -608,6 +608,7 @@ static int check_leaf_item(struct btrfs_fs_info *fs_info,
		struct btrfs_key *key, int slot)
		{
		int ret = 0;
		struct btrfs_chunk *chunk;

		switch (key->type) {
		case BTRFS_EXTENT_DATA_KEY:
		@@ -624,6 +625,11 @@ static int check_leaf_item(struct btrfs_fs_info *fs_info,
		case BTRFS_BLOCK_GROUP_ITEM_KEY:
		ret = check_block_group_item(fs_info, leaf, key, slot);
		break;
		case BTRFS_CHUNK_ITEM_KEY:
		chunk = btrfs_item_ptr(leaf, slot, struct btrfs_chunk);
		ret = btrfs_check_chunk_valid(fs_info, leaf, chunk,
		key->offset);
		break;
		}
		return ret;
		}

fs/btrfs/volumes.c

+9 −3

Original line number	Diff line number	Diff line
		@@ -6745,9 +6745,15 @@ static int read_one_chunk(struct btrfs_fs_info fs_info, struct btrfs_key key,
		length = btrfs_chunk_length(leaf, chunk);
		num_stripes = btrfs_chunk_num_stripes(leaf, chunk);

		/*
		* Only need to verify chunk item if we're reading from sys chunk array,
		* as chunk item in tree block is already verified by tree-checker.
		*/
		if (leaf->start == BTRFS_SUPER_INFO_OFFSET) {
		ret = btrfs_check_chunk_valid(fs_info, leaf, chunk, logical);
		if (ret)
		return ret;
		}

		read_lock(&map_tree->map_tree.lock);
		em = lookup_extent_mapping(&map_tree->map_tree, logical, 1);

Admin message