Commit 07584d4a authored Jul 13, 2014 by Rasmus Villemoes Committed by Greg Kroah-Hartman Jul 12, 2014

drivers: tty: Fix use-after-free in pty_common_install



In 2c964a2f "drivers: tty: Merge alloc_tty_struct and
initialize_tty_struct", I messed up the refactorization of
pty_common_install, causing use-after-free and NULL pointer derefs on
various error paths. This should fix it.

Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2c964a2f

drivers/tty/pty.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -388,7 +388,7 @@ err_deinit_tty:
		deinitialize_tty_struct(o_tty);
		free_tty_struct(o_tty);
		err_put_module:
		module_put(o_tty->driver->owner);
		module_put(driver->other->owner);
		err:
		kfree(ports[0]);
		kfree(ports[1]);

Admin message