Commit 074a6c65 authored Jan 14, 2016 by Joseph Qi Committed by Linus Torvalds Jan 14, 2016

ocfs2: access orphan dinode before delete entry in ocfs2_orphan_del



In ocfs2_orphan_del, currently it finds and deletes entry first, and
then access orphan dir dinode.  This will have a problem once
ocfs2_journal_access_di fails.  In this case, entry will be removed from
orphan dir, but in deed the inode hasn't been deleted successfully.  In
other words, the file is missing but not actually deleted.  So we should
access orphan dinode first like unlink and rename.

Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
Reviewed-by: Jiufei Xue <xuejiufei@huawei.com>
Cc: Mark Fasheh <mfasheh@suse.de>
Cc: Joel Becker <jlbec@evilplan.org>
Reviewed-by: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 32e49326

fs/ocfs2/namei.c

+9 −9

Original line number	Diff line number	Diff line
		@@ -2372,6 +2372,15 @@ int ocfs2_orphan_del(struct ocfs2_super *osb,
		(unsigned long long)OCFS2_I(orphan_dir_inode)->ip_blkno,
		name, strlen(name));

		status = ocfs2_journal_access_di(handle,
		INODE_CACHE(orphan_dir_inode),
		orphan_dir_bh,
		OCFS2_JOURNAL_ACCESS_WRITE);
		if (status < 0) {
		mlog_errno(status);
		goto leave;
		}

		/* find it's spot in the orphan directory */
		status = ocfs2_find_entry(name, strlen(name), orphan_dir_inode,
		&lookup);
		@@ -2387,15 +2396,6 @@ int ocfs2_orphan_del(struct ocfs2_super *osb,
		goto leave;
		}

		status = ocfs2_journal_access_di(handle,
		INODE_CACHE(orphan_dir_inode),
		orphan_dir_bh,
		OCFS2_JOURNAL_ACCESS_WRITE);
		if (status < 0) {
		mlog_errno(status);
		goto leave;
		}

		/* do the i_nlink dance! :) */
		orphan_fe = (struct ocfs2_dinode *) orphan_dir_bh->b_data;
		if (S_ISDIR(inode->i_mode))

Admin message