Commit 073b5bee authored Oct 07, 2013 by Mel Gorman Committed by Ingo Molnar Oct 09, 2013

sched/numa: Remove check that skips small VMAs



task_numa_work skips small VMAs. At the time the logic was to reduce the
scanning overhead which was considerable. It is a dubious hack at best.
It would make much more sense to cache where faults have been observed
and only rescan those regions during subsequent PTE scans. Remove this
hack as motivation to do it properly in the future.

Signed-off-by: Mel Gorman <mgorman@suse.de>
Reviewed-by: Rik van Riel <riel@redhat.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1381141781-10992-29-git-send-email-mgorman@suse.de


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 1bc115d8

kernel/sched/fair.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -1127,10 +1127,6 @@ void task_numa_work(struct callback_head *work)
		if (!vma_migratable(vma))
		continue;

		/* Skip small VMAs. They are not likely to be of relevance */
		if (vma->vm_end - vma->vm_start < HPAGE_SIZE)
		continue;

		do {
		start = max(start, vma->vm_start);
		end = ALIGN(start + (pages << PAGE_SHIFT), HPAGE_SIZE);

Admin message